When using the VBO integration to generate a new segment on a list, or to add addresses to an existing segment, you're presented with the following form.
This form displays a text field for entering in the new of a new segment, however, it's not always necessary, and in this context is somewhat confusing. The code looks like it's supposed to use the #states system to hide this field until you've 1.) chosen a list, and 2.) chosen the create new segment option from the list of segments that's provided after you choose a mailing list.
Looks like something might be off with the use of #states here.
The form itself still works as expected so this would just be a UX improvement.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 2484201-1-segment_form_states.patch | 593 bytes | eojthebrave |
| mailchimp_vbo_test | Site-Install 2015-05-06 11-47-55.jpg | 54.84 KB | eojthebrave |
Comments
Comment #1
eojthebraveLooks like the #states implementation to hide the field is using the wrong field name. Attached patch fixes the problem. With this applied, the text field for adding a new segment name will only display if/when you've chosen a list, and chosen to add a new segment to the list.
Comment #2
BabaYaga64 commentedI have applied this patch and it works to hide the add a new segment form. I've committed the changes to the 7.x-3.x branch.
Comment #3
jami commentedFix pushed to 7.x-3.4.
http://drupalcode.org/project/mailchimp.git/commit/295485f
Thanks for the great work eojthebrave and BabaYaga64!