Error message "Invalid group requested" on non-weblinks vocabulary

(a) I have changed the error text message to show the function it is called from, which will assist future debug. In this case it was:

"Invalid group requested (14) in function weblinks_get_tree."

(b) It was called from the related block and the reason for the error being displayed was that the $ismainlinkspage value in weblinks_get_tree() was TRUE, whereas it should be FALSE if this function is called from a block.

Here's a patch which solves both of these.

Thanks for testing, I did not try typing an incorrect url directly, so that's good. I was just checking that the message was not shown when a related block called the function.

Easy to fix - the test for $ismainlinkspage should only prevent the error message. The function still needs to return the empty array at that point, not continue on (where your errors were shown). Here's an updated patch. I also added a bit of in-code documentation.

argh ... this is not right either. We need the message to be shown when trying to go to /weblinks/nn when nn is not valid. So $ismainlinkspage is not the right thing to test for anyway. All we need is for the message not to be shown when this is called from the related block.

I'll do some more investigation.

I have found that the error is caused by the wrong terms being used in weblinks_blocks_block_view() and passed to _weblinks_blocks_related_block(). It happens when the weblinks standard vocabulary is added to the content type but a different vocabulary is being used for Web Links navigation. The node value $node->taxonomy_weblinks is hard-coded but it should use the field which has the current weblinks navigation vocab. Now that #2481521: Expand the information returned by _weblinks_vocabulary_field_info() is in, I can fix it properly, which was my eventual aim anyway.

The above is just the improvement in the error message adding the function which produced the error. I will work on the actual fix now.

There were a couple of reasons for the error messages
(a) If the site has a 'recent' or 'popular' block for a specific term, then the weblinks navigation vocabulary is switched to a different one, the term of that block is no longer applicable. This is fixed at the top of weblinks_blocks_block_view() by checking the vocabulary id of the term associated with the block being requested.
(b) In the related block section, we cannot assume that the field taxonomy_weblinks is the field being used to group weblinks. With the expansion of data returned by _weblinks_vocabulary_field_info() we can get the actual field name and use this instead.

The attached patch fixes both of these.

Thanks for testing.