Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Just noticed this little gremlin
FlagSimpleTest::testFlagForm
chooses to break its tasks into a series of do subtasks
so you can see at a high level what is going on in what order.
$this->doTestFlagAdd();
$this->doGlobalFlag();
$this->doTestFlagCounts();
$this->doTestHideFlagLinkFromTeaser();
$this->doTestUserDeletion();
unfortunately one on the do's is hidden from the list
as doTestFlagAdd() - daisy chaining and extra one ( doTestCreateNodeAndFlagIt ) at the end of its method.
so the trivial task becomes make sure doTaskCreateNodeAndFlagIt is call only in testFlagForm
Comment | File | Size | Author |
---|---|---|---|
#1 | continue-2482123-1.patch | 763 bytes | martin107 |
Comments
Comment #1
martin107 CreditAttribution: martin107 commentedComment #2
joachim CreditAttribution: joachim commentedNice! Committed.
I may need to reroll #2467013: review and refactor methods in tests, but good to get this fixed.