Just noticed this little gremlin

FlagSimpleTest::testFlagForm

chooses to break its tasks into a series of do subtasks

so you can see at a high level what is going on in what order.

$this->doTestFlagAdd();
$this->doGlobalFlag();
$this->doTestFlagCounts();
$this->doTestHideFlagLinkFromTeaser();
$this->doTestUserDeletion();

unfortunately one on the do's is hidden from the list

as doTestFlagAdd() - daisy chaining and extra one ( doTestCreateNodeAndFlagIt ) at the end of its method.

so the trivial task becomes make sure doTaskCreateNodeAndFlagIt is call only in testFlagForm

CommentFileSizeAuthor
#1 continue-2482123-1.patch763 bytesmartin107
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

martin107’s picture

Assigned: martin107 » Unassigned
Status: Active » Needs review
FileSize
763 bytes
joachim’s picture

Title: FlagSimetest - do not continue the process. » FlagSimpletest - do not continue the process.
Status: Needs review » Fixed

Nice! Committed.

I may need to reroll #2467013: review and refactor methods in tests, but good to get this fixed.

  • joachim committed fa5fc89 on 8.x-4.x authored by martin107
    Issue #2482123 by martin107: Changed FlagSimpleTest::doTestFlagAdd() so...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.