As other modules that rely on this and use simpletest, and since simpletest is strict, schema is required.

CommentFileSizeAuthor
#10 inline_entity_form-form_schema-2481919-10.patch872 byteswoprrr
#9 inline_entity_form-form_schema-2481919-9.patch1.43 KBwoprrr
#6 inline_entity_form-form_schema-2481919-6.patch1.38 KBwoprrr
#4 inline_entity_form-form_schema-2481919-4.patch1.11 KBwoprrr
inline_entity_form_schema-1.patch1.5 KBjoshtaylor

Comments

joshtaylor’s picture

joshtaylor commented
Status: Active » Needs review
joshtaylor’s picture

joshtaylor commented

Bump? This is required for testing contrib modules with simpletest.

woprrr’s picture

woprrr commented
Status: Needs review » Needs work

I m not sure for why, but after apply this patch IEF not work after drush cache-rebuild.
After delete your patch and drush cache-rebuild he work fine.

The schemas looks good yet, I will also invest!

woprrr’s picture

woprrr commented
Status: Needs work » Needs review
Issue tags: +inline entity form, +Drupal 8.x
StatusFileSize
new inline_entity_form-form_schema-2481919-4.patch1.11 KB

I found eventually it generated an error, blocking the ajax module . " Uncaught Exception PHP InvalidArgumentException : " Missing required properties for an entity EntityDisplay "

Here is the complete patch everything works fine for me. Can you confirm that this works out for you ?

webflo’s picture

webflo commented
Status: Needs review » Needs work 
+++ b/config/schema/inline_entity_form.schema.yml
@@ -0,0 +1,30 @@
+inline_entity_form.entity_form_display.*.*.*:
+  type: config_entity
+  label: 'Inline Entity Form display'
+  mapping:

Are you sure? It looks like the schema is for the field widget and not a entity form display. I think the proper prefix is field.widget.settings.inline_entity_form_multiple similar to other field widgets ins core.

woprrr’s picture

woprrr commented
Assigned: joshtaylor » Unassigned
Status: Needs work » Needs review
StatusFileSize
new inline_entity_form-form_schema-2481919-6.patch1.38 KB

Thanks @webflo ! you are right !! I am me based on what is right for entity references. I think it's good now. I also add the patterns of single widget too. In this connection on this widget, there is an exit or I question its usefulness.

webflo’s picture

webflo commented
Status: Needs review » Needs work 
+++ b/config/schema/inline_entity_form.schema.yml
@@ -0,0 +1,47 @@
+    allow_existing:
+    type: boolean
+    label: "ALlow existing"
+    match_operator:
+    type: string

The indentation is not correct. It was correct in your previous patch.

webflo’s picture

webflo commented 
+++ b/config/schema/inline_entity_form.schema.yml
@@ -0,0 +1,47 @@
+    allow_existing:
+    type: boolean
+    label: "ALlow existing"
+    match_operator:
+    type: string

The indentation is not correct. It was correct in your previous patch.

woprrr’s picture

woprrr commented
Status: Needs work » Needs review
StatusFileSize
new inline_entity_form-form_schema-2481919-9.patch1.43 KB

OH ! SORRY \O/ !! I fix it now !

woprrr’s picture

woprrr commented
StatusFileSize
new inline_entity_form-form_schema-2481919-10.patch872 bytes

To follow the outcome here https://www.drupal.org/node/2491527#comment-9940087 the corresponding scheme.

joshtaylor’s picture

joshtaylor commented

Can we get #9 reviewed and committed, which fixes testing in contrib modules which use IEF.

#10 would be good when that issue is in (maybe merge #10 into that issue?).

joshtaylor’s picture

joshtaylor commented
Status: Needs review » Reviewed & tested by the community

The last submitted patch, inline_entity_form_schema-1.patch, failed testing.

The last submitted patch, inline_entity_form_schema-1.patch, failed testing.

webflo’s picture

webflo commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed #9. 6407d99

  • webflo committed 6407d99 on 8.x-1.x 
    Issue #2481919 by woprrr, joshtaylor, webflo: Adds schema for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.