Make the node entity's revision_log untranslatable

Makes sense to me, good catch!
I don't see any use case where we could want to translate the revision log.

Can you provide a failing test?

I agree this looks good. Not 100% sure how would this be tested? Retrieve the metadata of the node fields and verify the revision log is not translatable looks fine to me.

Is it sufficient to test that revision_log is not translatable or should we test that revision_log is not lost after editing the translation of a node?

Seems like making the revision log not translatable now breaks quickedit. Concurrently editing a node with the full form and the quickedit form doesn't throw an error.
I'm trying to reproduce this bug and the expected behavior from the UI and I haven't succeeded yet.

I just want to make sure if I update ->setTranslatable(TRUE) to FALSE then if throws the error or not. then I will add the tests. I have run the tests on local. it got passed.

Looks good to me, thanks!

There is no movement on #2506213: Update content entity changed timestamp on UI save for over a month, so removing from sprint :/

Due to the fact that that #2506213: Update content entity changed timestamp on UI save is RTBC and #2465907: Node revision UI reverts multiple languages when only one language should be reverted is affected by this issue I set this one back to "Needs Review"

1. +++ b/core/modules/content_translation/src/Tests/ContentTranslationStandardFieldsTest.php
   @@ -77,4 +77,12 @@ public function testFieldTranslatableArticle() {
   +  }
   

   Missing empty line after closing brace.

2. +++ b/core/modules/quickedit/src/Tests/QuickEditLoadingTest.php
   @@ -502,8 +502,11 @@ public function testConcurrentEdit() {
   -      // Save the node on the regular node edit form.
   -      $this->drupalPostForm('node/1/edit', array(), t('Save'));
   +      // Save the node on the regular node edit form. Saving the node without
   +      // any changes will not update the changed timestamp, as the ChangedItem
   +      // now has a logic to check if the entity changed and only then update its
   +      // value. Thus we have to force update the node entity.
   +      $this->drupalPostForm('node/1/edit', array('changed' => time()), t('Save'));
   

   I think this can be removed now.

+++ b/core/modules/content_translation/src/Tests/ContentTranslationStandardFieldsTest.php
@@ -77,4 +77,13 @@ public function testFieldTranslatableArticle() {
+    $this->assertNoFieldByXPath("//input[@id='edit-settings-node-article-fields-revision-log']");
+  }
+  ¶
 }

Trailing white-space, we cannot let that sneak in, sorry :)

Removed the white space, no credits, please.

Bring it back on sprint for tracking then :)

This looks majorish

Committed 4a99201 and pushed to 8.0.x. Thanks!

Superb, thanks all!