Follow-up for #1942682: Blank detail view in dblog for deleted users.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because this method should be used instead of '0'
Issue priority Not critical
Prioritized changes The main goal of this issue is to use consistent code within core, thus reducing fragility.
CommentFileSizeAuthor
#5 2479593.png18.96 KBzaporylie
#3 dblog-getanonymoususer-2479593-03.patch894 bytesjhedstrom
#3 dblog-getanonymoususer-2479593-03.patch894 bytesjhedstrom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Issue summary: View changes
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Title: Use constant for anonymous user in DblogController::eventDetails() » Use User::getAnonymousUser() in DblogController::eventDetails()
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
Issue summary: View changes
Status: Active » Needs review
FileSize
dblog-getanonymoususer-2479593-03.patch894 bytes
dblog-getanonymoususer-2479593-03.patch894 bytes

Added a beta-eval.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 commented
zaporylie’s picture

zaporylie
he/him
Primary language Polish
CreditAttribution: zaporylie at Ny Media AS commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
2479593.png18.96 KB

Patch looks great, works as expected and also improves performance a little bit (measured with blackfire.io). RTBC!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed

Nice cleanup! Committed and pushed to 8.0.x. Thanks!

  • xjm committed 8067ab5 on 8.0.x 
    Issue #2479593 by jhedstrom, zaporylie: Use User::getAnonymousUser() in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.