Problem/Motivation

#2468873: Test that the authentication provider doesn't leak authentication credentials from the previous request introduced a reusable BasicAuthTestTrait providing the basicAuthGet which does not suffer from leaking curloptions to subsequent requests.

Proposed resolution

Use the new trait in the original basic auth test.

Remaining tasks

Review & Commit.

User interface changes

None.

API changes

None.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task
Issue priority Normal
Unfrozen changes Unfrozen because it only changes tests.
CommentFileSizeAuthor
#1 use_basicauthtesttrait-2479515-1.patch1.81 KBznerol

Comments

znerol’s picture

znerol commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new use_basicauthtesttrait-2479515-1.patch1.81 KB
znerol’s picture

znerol commented
Issue summary: View changes
pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Needs review » Reviewed & tested by the community

Very straightforward fix. This improves code reuse and reduces duplicated code. This is only affecting test code so this is unfrozen and allowed according to the beta criteria. Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice catch.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed df6519a on 8.0.x 
    Issue #2479515 by znerol: Use BasicAuthTestTrait in BasicAuthTest

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.