At the moment we have instances where testbots runs tests for 3 hours and then give up. This is because something goes wrong. I think we should reduce the time limit from 180 minutes to 60 minutes. Because:

  • If a patch did introduce a regression that made current testbot time go form 30 minutes to 60 minutes we'd want to know about this before committing the patch - test failures are an ideal way to catch this.
  • If the testbot is faulty people get quicker feedback and the alarm is raised sooner
  • We can fix testbots quicker therefore not wasting capacity
  • If HEAD fails and then gets stuck on a long run we get notified sooner and can fix it quicker - unblocking all tests.

@xjm has raised concerns that in the past tests that exceeded the time limit caused the bot to loop but I have seen test runs cut out and feedback correctly after the 180 minute time limit recently.

Action to take

The variable pifr_client_timeout should be set to 60.

Comments

isntall’s picture

isntall commented
Assigned: Unassigned » isntall
Status: Active » Needs review

I've pushed a change to the drupaltestbot-puppet repo that has changed the pifr_client_timeout to 60.

jthorson’s picture

jthorson commented
Status: Needs review » Fixed

So this is complete, correct?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.