Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I basically just want to get the trivial patch of the month award.
| Comment | File | Size | Author |
|---|---|---|---|
| trivial_patch_of_the_month.patch | 929 bytes | adammalone | |
Comments
Comment #1
adammaloneComment #2
ArlaGot here through the issue tag. Nice ;)
But when I wanted to confirm the typo I first looked at the wrong Connection class, and found some more (regex: /
[^\s*]/). So maybe this issue could be extended to remove whitespace typos more generally? *killjoy*Comment #3
cilefen CreditAttribution: cilefen commentedComment #4
cilefen CreditAttribution: cilefen commentedComment #6
EvanSchisler CreditAttribution: EvanSchisler at Acro Commerce commentedI read through the code and applied it to a clean install of D8. Nothing broke and everything works (Doing my core mentoring for the first time!)
Comment #7
darol100 CreditAttribution: darol100 as a volunteer and commented@EvanSchisler this should be RTCB then ?
Comment #8
valthebald+1 to RTBC. Hard to imagine how this patch can break anything, and documentation patches are unfrozen anyways
Comment #9
darol100 CreditAttribution: darol100 as a volunteer and commentedWorst case scenario would be that the it would fail the automatic test. Just like #8 said this would not break anything.
Comment #10
alexpottCommitted fde9561 and pushed to 8.0.x. Thanks! (This is a docs fix and docs are unfrozen in beta)