The module expects that the files are to be in a library directory called jquery.imagesloaded and the files should be named jquery.imagesloaded.js and jquery.imagesloaded.min.js

However, when you download the project from github (https://github.com/desandro/imagesloaded), the file and directory names don't match. Neither the directory nor the file names have the jquery prefix. Actually, the files that should be used are named imagesloaded.pkgd.js and imagesloaded.pkgd.min.js.

I will modify the js library names to match in order to make the module work for my site, but it seems like it would be better for end users to update the module code to use the file/directory names provided by the imagesloaded project, especially if other modules require the same library.

Thanks,
Julia

Comments

juliakoelsch’s picture

juliakoelsch commented
Issue summary: View changes
juliakoelsch’s picture

juliakoelsch commented
Issue summary: View changes
matthijs’s picture

matthijs
Primary language Dutch
commented
Status: Active » Postponed

If you download the suggested library version (see the README) the file names do have a "jquery." prefix, but it was removed in the more recent versions. It would be great to support them both, so I'll welcome any patch that makes this happen!

lightweight’s picture

lightweight commented

I just now tried setting this up and have found that I can simply copy either imagesloaded.pkgd.js or imagesloaded.pkgd.min.js and link it to jquery.imagesloaded.js, like this (cd'd into the sites/all/libraries/jquery.imagesloaded directory):

ln -sf imagesloaded.pkgd.min.js jquery.imagesloaded.js

and the manualcrop module seems happy.

Anonymous’s picture

Anonymous (not verified) commented
Related issues: +#2194023: Support version arguments differing by variant

It looks like this will depend on #2194023: Support version arguments differing by variant...

jelo’s picture

jelo commented

I am trying to install the module with the imagesloaded library and am unable to determine the correct file name for the js file to get it recognized. I tried
imagesloaded.pkgd.min.js
jquery.imagesloaded.pkgd.min.js
jquery.imagesloaded.min.js

Which one should work if you don't mind me asking?

matthijs’s picture

matthijs
Primary language Dutch
commented

You should have the script twice:
- jquery.imagesloaded -> includes the version header for the status page (optional)
- jquery.imagesloaded.min.js -> this one is used

sylvain_a’s picture

sylvain_a commented

#7 works, but more precisely:
- rename: imagesloaded.js --> jquery.imagesloaded.js
- rename: imagesloaded.pkgd.min.js --> jquery.imagesloaded.min.js

abdhomsi’s picture

abdhomsi commented

Thanks, saved my time.