If you are adding paragraphs in paragraphs and you exceed the recursive paragraph limit, instead of displaying the "The paragraphs item form has not been embedded to avoid recursive loops." error message, an empty tabledrag entry is created.

If you try to remove it, then the error message is displayed.

CommentFileSizeAuthor
#7 recursive-message-2477631-1.patch1013 bytesjeroen.b
#1 recursive-message-2477631-1.patch1013 bytesjeroen.b

Comments

jeroen.b’s picture

jeroen.b commented
Status: Active » Needs review
StatusFileSize
new recursive-message-2477631-1.patch1013 bytes

What do you think of the attached patch?

Status: Needs review » Needs work

The last submitted patch, 1: recursive-message-2477631-1.patch, failed testing.

jeroen.b’s picture

jeroen.b commented
Version: 7.x-1.0-beta6 » 7.x-1.x-dev

Status: Needs work » Needs review

jeroen.b queued 1: recursive-message-2477631-1.patch for re-testing.

jeroen.b’s picture

jeroen.b commented
Status: Needs review » Needs work
jeroen.b’s picture

jeroen.b commented
Status: Needs work » Needs review
jeroen.b’s picture

jeroen.b commented
StatusFileSize
new recursive-message-2477631-1.patch1013 bytes
jeroen.b’s picture

jeroen.b commented

Meh, for some reason the D7 tests are broken due to dependency enabling issues...

soapboxcicero’s picture

soapboxcicero commented

Sorry it took me so long to get back. I just tested against rc1.

This works, in that it displays the message, but only if I set PARAGRAPHS_RECURSION_LIMIT to 1 and then create 3 nested paragraphs. I added a watchdog message after the recursion check to make sure I wasn't going crazy:

watchdog('tst', 'paragraphs rec limit hit: ' . $recursion . ' of ' . PARAGRAPHS_RECURSION_LIMIT);

and it logs "paragraphs rec limit hit: 3 of 1"

If I leave the recursion limit at 20, after adding 3 paragraphs there's no error message and no paragraph form.

Very perplexing.

jeroen.b’s picture

jeroen.b commented

Are you sure that's not caused by something else like the form input limit in PHP?

jeroen.b’s picture

jeroen.b commented
Status: Needs review » Closed (outdated)