Comments

seanb’s picture

Nice patch! +1

There should be a easy_breadcrumb.api.php file with a hook example though.

greg boggs’s picture

Status: Active » Reviewed & tested by the community
seanb’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new1.9 KB

I've added the api file and also provided another hook. Sometimes you want to alter the breadcrumb by providing a custom alias instead of changing the calculated breadcrumb. This way the expensive calculations to get al the paths and page titles can be used more easily to do the changes. The original hook from the first patch also seem to make sense, so I left it in there.

Please review!

frob’s picture

Status: Needs review » Needs work

The patch will not apply for me. It is expecting the file easy_breadcrumbs.api.php to already exist.

seanb’s picture

Using patch -p1 should do the trick. New files won't show up so I use git add -N first. After this the patch looks like this :(

frob’s picture

The issue is that development is being done in the master branch and not in 7.x-1.x

Drupal Git guidelines recommend not using a master branch because it is confusing when multiple versions of drupal could be supported by that master branch.
https://www.drupal.org/empty-git-master

jkingsnorth’s picture

Status: Needs work » Needs review
StatusFileSize
new1.91 KB

Re-rolled patch against 7.x-2.x.

I think the structure of the $breadcrumb variable should be explained somewhere, since it is a render array (ie: not the same format as the normal drupal breadcrumb, which is just an array of links).

The easy_breadcrumb $breadcrumb has 'content', 'class' and 'url' for each element.

greg boggs’s picture

I agree, are you willing to add the documentation to this patch, with D8 released, maintenance on this module has slowed down, but it would be good to get this patch committed soon.

jkingsnorth’s picture

Hi Greg, since the variable is passed around the place which function do you think it would it be best to document the $breadcrumb variable in? Happy to add it to the patch.

tatarbj’s picture

Version: 7.x-2.12 » 7.x-2.x-dev
StatusFileSize
new1.88 KB

I've rechecked what happened here and planning to make it released in the next 7.x one. For this based on 7.x-2.x i've rerolled the patch and put the drupal_alter()s where they make the most sense, api file is also added.
Please review it!
Cheers,
Balazs.

greg boggs’s picture

Status: Needs review » Reviewed & tested by the community

  • Greg Boggs committed 1a789b4 on 7.x-2.x authored by tatarbj
    Issue #2476339 by seanB, JKingsnorth, tatarbj: Ability to alter links...
tatarbj’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.