Closed (fixed)
Project:
Easy Breadcrumb
Version:
7.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
23 Apr 2015 at 06:04 UTC
Updated:
25 Jul 2017 at 15:05 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
seanbNice patch! +1
There should be a easy_breadcrumb.api.php file with a hook example though.
Comment #2
greg boggsComment #3
seanbI've added the api file and also provided another hook. Sometimes you want to alter the breadcrumb by providing a custom alias instead of changing the calculated breadcrumb. This way the expensive calculations to get al the paths and page titles can be used more easily to do the changes. The original hook from the first patch also seem to make sense, so I left it in there.
Please review!
Comment #4
frobThe patch will not apply for me. It is expecting the file easy_breadcrumbs.api.php to already exist.
Comment #5
seanbUsing patch -p1 should do the trick. New files won't show up so I use git add -N first. After this the patch looks like this :(
Comment #6
frobThe issue is that development is being done in the master branch and not in 7.x-1.x
Drupal Git guidelines recommend not using a master branch because it is confusing when multiple versions of drupal could be supported by that master branch.
https://www.drupal.org/empty-git-master
Comment #7
jkingsnorth commentedRe-rolled patch against 7.x-2.x.
I think the structure of the $breadcrumb variable should be explained somewhere, since it is a render array (ie: not the same format as the normal drupal breadcrumb, which is just an array of links).
The easy_breadcrumb $breadcrumb has 'content', 'class' and 'url' for each element.
Comment #8
greg boggsI agree, are you willing to add the documentation to this patch, with D8 released, maintenance on this module has slowed down, but it would be good to get this patch committed soon.
Comment #9
jkingsnorth commentedHi Greg, since the variable is passed around the place which function do you think it would it be best to document the $breadcrumb variable in? Happy to add it to the patch.
Comment #10
tatarbjI've rechecked what happened here and planning to make it released in the next 7.x one. For this based on 7.x-2.x i've rerolled the patch and put the drupal_alter()s where they make the most sense, api file is also added.
Please review it!
Cheers,
Balazs.
Comment #11
greg boggsComment #13
tatarbj