Closed (fixed)
Project:
Signup
Version:
5.x-2.4
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
16 Apr 2008 at 20:40 UTC
Updated:
24 Aug 2008 at 06:02 UTC
Jump to comment: Most recent file
We wanted admins to be able to add people who had called in to sign up for an event after the event was closed. It was a simple one line mod fix - that could be enhanced with a warning message, but I think would do what most people want.
I'm not skilled in patch making and since the mod is so simple...
Change line 1354 in v 5.x-2.4 from
if (user_access('sign up for content') && $node->signup_status) {
to
if ((user_access('sign up for content') && $node->signup_status) || user_access('administer all signups')) {
-Preston
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 247573_signup_admin_no_add_to_closed.patch | 1.09 KB | dww |
| #2 | signup_admin_addto_closed.patch | 638 bytes | ptone |
Comments
Comment #1
pelicani commentedPatches are really easy, try it out when you get a chance.
http://drupal.org/patch/create
Then post a patch, it's how things are done around here.
And makes maintaining a module, manageable ; )
Comment #2
ptone commentedAlrighty then ;-)
Patch attached.
Comment #3
dwwActually, I think the bug is that the form is presented at all when signups are closed for an event. If signups are closed, they're closed. If the admin wants to add more people, they should have to increase the signup limit or manually reopen, IMHO. See attached patch.
Comment #4
duellj commentedTested. Thanks dww.
Comment #5
dwwCommitted to HEAD. Thanks for testing, duellj.
Comment #6
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.