Problem/Motivation

PageCacheTest::testPageCacheAnonymous403404() fails randomly due to usage of TestBase::randomString() instead of TestBase::randomName() in url.

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#8 2474835.6.patch609 bytesalexpott
#6 2474835.6.patch607 bytesalexpott
#4 2474835.4.patch684 bytesalexpott
#1 2474835-random-random.diff617 bytesznerol
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

znerol’s picture

znerol CreditAttribution: znerol commented
Status: Active » Needs review
FileSize
2474835-random-random.diff617 bytes

Status: Needs review » Needs work

The last submitted patch, 1: 2474835-random-random.diff, failed testing.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

Looks good, but failed?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Priority: Normal » Critical
Status: Needs work » Needs review
Issue tags: +Random test failure
FileSize
2474835.4.patch684 bytes

It's randomMachineName()

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Needs review » Reviewed & tested by the community

if green

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
FileSize
2474835.6.patch607 bytes

Actually randomness is just not important here.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 2474835.6.patch, failed testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs work » Reviewed & tested by the community
FileSize
2474835.6.patch609 bytes

ugh.

  • effulgentsia committed ad0c647 on 8.0.x 
    Issue #2474835 by alexpott, znerol: Random test fail in PageCacheTest::...
effulgentsia’s picture

effulgentsia CreditAttribution: effulgentsia at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.