Problem/Motivation

TestFormBuilder existed to help wrap procedural functions for testing FormBuilder.
#2456983: Five methods in class TestFormBuilder are dead code. Remove them. removed a bunch of stale methods.
#2226621: Remove usage of element_info(), element_child() and element_children(). Deprecate element_info_property(). should have removed the final one, but due to a bad reroll, reintroduced the old ones.

Proposed resolution

Remove TestFormBuilder for real.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 2474761.patch2.17 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Status: Active » Needs review
FileSize
2474761.patch2.17 KB
cilefen’s picture

cilefen CreditAttribution: cilefen commented

+1 RTBC if green

cilefen’s picture

cilefen CreditAttribution: cilefen commented
Status: Needs review » Reviewed & tested by the community

There is not much to say. The class is unnecessary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Test only code change and less code. Nice. Committed 0e699d6 and pushed to 8.0.x. Thanks!

  • alexpott committed 0e699d6 on 8.0.x 
    Issue #2474761 by tim.plunkett: Remove TestFormBuilder completely

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.