Problem/Motivation

Right now, there is no maintainer for the link.module.

I have been triaging, reviewing, and sending patches to the link.module. In addition, I have experience mentoring others, including sprints at DrupalCon Amsterdam (I love that orange shirt).

I've read the suggestions for the new maintainer's policy, and I'm also aware of the actual responsibilities.

I know that @sun also had interest in maintaining this module: https://www.drupal.org/node/1823042#comment-6695156
It would be cool to add him too, if he is still interested.

Today's numbers:

Open issues for link.module: 20
My contributions to link.module:

Proposed resolution

Add Mac_Weber to MAINTAINERS.txt for the link.module

Remaining tasks

Decide if anyone has an issue with this?
Ask @sun if he also has interest in maintaining this module.
Patch maintainers.txt

CommentFileSizeAuthor
#13 Link-Mac_Weber-2.patch703 bytesmac_weber
Link-Mac_Weber.patch674 bytesmac_weber

Comments

mac_weber’s picture

mac_weber commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, Link-Mac_Weber.patch, failed testing.

Status: Needs work » Needs review

Mac_Weber queued Link-Mac_Weber.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, Link-Mac_Weber.patch, failed testing.

mac_weber’s picture

mac_weber commented
Version: 8.1.x-dev » 8.0.x-dev
Status: Needs work » Needs review

Testbot is failing for no reason.

Mac_Weber queued Link-Mac_Weber.patch for re-testing.

afeijo’s picture

afeijo
Primary language Portuguese, Brazil
Location Porto Alegre
commented

I support @Mac_Weber to be the maintainer for the link module!

afeijo’s picture

afeijo
Primary language Portuguese, Brazil
Location Porto Alegre
commented
Status: Needs review » Reviewed & tested by the community

as no one has issues, I'm switching to RTBC

xjm’s picture

xjm
she/her
Primary language English
commented
Assigned: Unassigned » dries

Exciting, thanks @Mac_Weber! Assigning to @Dries for review.

mac_weber’s picture

mac_weber commented

@afeijo it is really cool getting support from a good programmer and community supporter like you. Thank you!

Thank you @xjm!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, Link-Mac_Weber.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Needs reroll

.

mac_weber’s picture

mac_weber commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new Link-Mac_Weber-2.patch703 bytes

Rerolled

barraponto’s picture

barraponto
he / him
commented
Status: Needs review » Reviewed & tested by the community

I don't see any actual change here, seems like just a reroll that applies cleanly.
I hope there is an open issue to deal with the inconsistency with http/https in the drupal.org links in that file.

xjm’s picture

xjm
she/her
Primary language English
commented

@barraponto, coincidentally, I just asked for the same thing in a followup request for #2489912: Update Drupal.org URL in core modules. :) So the format in @Mac_Weber's patch is the "correct" one per that issue.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x! Welcome to the MAINTAINERS team, Mac! Thanks for all your help.

  • Dries committed 5866bee on 8.0.x 
    Issue #2474677 by Mac_Weber: Add Mac_Weber to MAINTAINERS.txt for the...
mac_weber’s picture

mac_weber commented

Thank you everyone!
@Dries any special offer for maintainers to take the grand master certification exams? =D

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.