Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Currently, the link field auto-inserts help text based on what is selected under "allowed field type" in the field configuration.
"External links only" results in the help text "This must be an external URL such as http://example.com."
"Both internal and external links" results in the help text "Start typing the title of a piece of content to select it. You can also enter an internal path such as /node/add or an external URL such as http://example.com. Enter <front> to link to the front page."
("Internal links only", interestingly, doesn't generate any help text, including the relevant help text from the "both" option.)
Proposed resolution
Add help text to the option "Internal links only"
Remaining tasks
Send first patch
User interface changes
Adds help text
Without the patch:
With the patch:
API changes
none
Reported by
Issue reported by @rootwork on #2462087: Make displaying fields' help text optional
RC phase evaluation
| Issue category | Documentation bug because the help text for "internal links" is present when the "both" option is selected, but not when the "internal only" option is selected. |
|---|---|
| Issue priority | Normal because it's a site-builder DX issue with documentation. |
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | add_help_text_to_internal_only-2474469-11.patch | 1.47 KB | Mac_Weber |
| #4 | link-2474469-with-patch.png | 20.5 KB | rootwork |
| #4 | link-2474469-without-patch.png | 13.6 KB | rootwork |
| #1 | add_help_text_to_internal_only-2474469-1.patch | 1.4 KB | Mac_Weber |
Comments
Comment #1
Mac_Weber CreditAttribution: Mac_Weber commentedComment #2
Mac_Weber CreditAttribution: Mac_Weber commentedComment #3
rootworkUpdated what I think was a typo in the issue title.
Comment #4
rootworkScreenshots--
Without patch:
With patch:
Comment #5
Mac_Weber CreditAttribution: Mac_Weber commented@rootwork thank you for catching the typo and sending the screenshots!
Let me know if you have reviewed the patch and feel free to switch the status to "RTBC" if you don't find any problems.
Comment #6
Mac_Weber CreditAttribution: Mac_Weber commentedComment #7
rootworkI'm sorry I never came back to this, but remarkably the patch from #1 still applies. I just confirmed this, and the screenshots from #4 are still the result. So I think this is RTBC.
Comment #8
rootworkUpdated summary with RC phase evaluation.
Comment #9
xjmThis should also mention that it can use autocomplete. The equivalent text with external links is:
I'm not sure on whether this change can go into 8.0.0 post-release or whether it should wait for 8.1.x. It does change the user interface in a small way in this case, but it does not break any existing strings so there's not really any disruption, and it also just plain doesn't make sense for there to be help text with the one option but not the other.
Comment #10
xjmAlso removing the note in the summary about it being a documentation change -- this is changing user interface text. "Documentation" refers to developer documentation that is never displayed on the site.
Thanks!
Comment #11
Mac_Weber CreditAttribution: Mac_Weber commentedChanged the text to:
'This must be an internal path such as /node/add. You can also start typing the title of a piece of content to select it. Enter <front> to link to the front page.'Comment #14
osmanComment #15
mallezieThis still apllies, works, and is clean.
Comment #17
xjmCommitted 1f97aeb and pushed to 8.3.x. Thanks!