I'm sure there's a canonical list somewhere, but looking at LINK_DOMAINS its clear we're missing some domain extensions. For example, .io and .website are gaining popularity. This first patch adds those two extensions.
I believe we may have reached a time where one can't reliably do a simple domain check to see if a link is valid and you should rely entirely on physically pinging the url to make sure it really validates. But perhaps that's another issue for another day.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | link-website-domain-2.patch | 5.78 KB | christophweber |
| #4 | link-website-domain-1.patch | 704 bytes | rlnorthcutt |
| #3 | rejectedlink.jpg | 80.99 KB | jensimmons |
| link-website-domain-0.patch | 667 bytes | saltednut |
Comments
Comment #1
saltednutThis seems to be a pretty good list: http://www.iana.org/domains/root/db
Comment #2
David_Rothstein commentedComment #3
jensimmons commentedHalp! Rejected link! Need fix. Need.
Comment #4
rlnorthcuttHere is an updated patch with a few more TLDs...
Comment #5
christophweber commentedI think this update is sorely needed as new domains using the expanded top level domains are popping up left and right. Just today Google announced its restructuring with Alphabet (https://abc.xyz) being its holding company, and Link module promptly rejected abc.xyz.
Either brantwynn's original suggestion to just rely on a successful ping to the linked site, or using the list from IANA as suggested by brantwynn in #1 would work well IMHO.
Comment #6
christophweber commentedHere's a patch based on the full domain list at http://www.iana.org/domains/root/db as of 8-12-2015. All non-ASCII TLDs have been removed since I cannot vouch for end-to-end UTF-8 encoding on all server stacks, and don't want to create issues for anyone.
Comment #8
christophweber commentedTry harder, this patch should work against dev.
Comment #9
quicksketchCould we please consolidate with #2299657: Allow any TLD because site admins can never keep up with ICANN? Both issues have discussions on fixes. That issue is older but does not (yet) have a patch.
Comment #10
saltednutIf we must. This thread actually had participation from the maintainer and active patches being worked on, so it seems like a bad move to just close it as a dupe and not even mention it in the other issue.
Comment #11
pringlz commentedPlease add form text area to module Link for custom adding domain list. It was better than patching. If someone want to update module in future and new version will be not contain some domain - we will have a lot of errors with existing content.