Problem

XssTest test class in views_ui/src/Tests lacks the name of the test in class annotation comments, therefore this test is never discovered and is never run by the testing system, not even Drupal QA testbot.

Proposed resolution

Ensure the MissingSummaryLineException is not caught during test discovery.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Files: 
CommentFileSizeAuthor
#9 2473907.9.patch38.08 KBalexpott
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 94,437 pass(es). View
#9 5-9-interdiff.txt36.08 KBalexpott
#5 2473907.5.patch3.3 KBalexpott
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 94,481 pass(es), 13 fail(s), and 0 exception(s). View
#5 1-5-interdiff.txt2.92 KBalexpott
#5 2473907.5.test-only.patch879 bytesalexpott
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Failed to run tests: failed during invocation of run-tests.sh. View
#1 views_ui-xsstest-2473907.patch388 bytesmaijs
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 93,047 pass(es). View

Comments

maijs’s picture

FileSize
388 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 93,047 pass(es). View

Changing the attribution.

maijs’s picture

Status: Active » Needs review
maijs’s picture

Issue summary: View changes
jcnventura’s picture

Status: Needs review » Reviewed & tested by the community

Good catch.

alexpott’s picture

Title: XssTest test in views_ui is not discovered » Tests not being run by testbot due to missing summary line
Issue summary: View changes
Priority: Normal » Major
Status: Reviewed & tested by the community » Needs review
Related issues: +#2422019: Don't use reflection for parsing test annotations
FileSize
879 bytes
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Failed to run tests: failed during invocation of run-tests.sh. View
2.92 KB
3.3 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 94,481 pass(es), 13 fail(s), and 0 exception(s). View

There are more tests affected by this. Bug introduced by #2422019: Don't use reflection for parsing test annotations

Fingers-crossed all the tests pass... alexpott--

The last submitted patch, 5: 2473907.5.test-only.patch, failed testing.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Wow

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: 2473907.5.patch, failed testing.

alexpott’s picture

Status: Needs work » Needs review
FileSize
36.08 KB
38.08 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 94,437 pass(es). View

More hardening and fixing the failures.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Perfect!

neclimdul’s picture

Before: PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 94,345 pass(es).
After: PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 94,436 pass(es).

No new tests. Good job guys!

catch’s picture

Status: Reviewed & tested by the community » Fixed

Ouch, nice find.

Committed/pushed to 8.0.x, thanks!

  • catch committed 5eb13a9 on 8.0.x
    Issue #2473907 by alexpott, maijs: Tests not being run by testbot due to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.