Use minified version of jquery once plugin.

The official minified version has a sourcemap, so I added that file as well to avoid 404. I kept the unminified source so that actually debugging and stepping into the plugin works.

CommentFileSizeAuthor
core-js-minified-once.patch2.81 KBnod_

Issue fork drupal-2473837

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

I manually tested this and it works. (every page uses it, for example the toolbar)
To avoid confusion.

- We added a minified version
- We keep the original one for debug purposes (there is a source map that links the minified file to the regular one)
- We were already on the latest release so we didn't need any changes for the un-minified one.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Awesome, thanks so much folks!

Committed and pushed to 8.0.x.

  • webchick committed 9c49f82 on 8.0.x 
    Issue #2473837 by nod_, aspilicious: Use minified jQuery once

Status: Fixed » Needs work

The last submitted patch, core-js-minified-once.patch, failed testing.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs work » Fixed
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Yes, yes, testbot.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

codebymikey made their first commit to this issue’s fork.