Project Release history XML outputs stream wrapper uris

The patch required a re-role, but this is RTBC.

URI param is important as noted or all urls are http://default...

drush release-create-history --uri=http://updates.mysite.org

I wonder how d.o can run without this patch.

Drupal.org alters it with a project_release_download_base_* variable, see project_release_project_behavior_settings(). We'll have to make sure this handles those URLs properly.

It works with custom http:// and https://, but not for ftp:// urls.

The root cause is file_create_url(). FTP urls require that the site has FTP stream wrapper registered.

Should we do this inside the project module or in an external module? Maybe d.o can just install storage api and we are done.

It's not the patch here that is wrong.

This snippet allows using FTP links. But I fear that is not clean enough for sites that may use storage API and also define ftp stream wrapper. However it proves that this file_create_url() works with the patch and ftp:// links.

/**
 * Implements hook_stream_wrappers().
 */
function project_release_stream_wrappers() {
  return array(
    'ftp' => array(
      'name' => t('FTP distribution files'),
      'class' => 'ProjectFtpStreamWrapper',
      'description' => t('Provides read-only paths to ftp distribution files.'),
      'type' => STREAM_WRAPPERS_READ,
    ),
  );
}

/**
 * Default FTP files (ftp://) stream wrapper class.
 */
class ProjectFtpStreamWrapper extends DrupalPublicStreamWrapper {
  function getExternalUrl() {
    return $this->uri;
  }
}

We should add a form validation to the node type form to check if the entered scheme is supported by Drupal.

This patch validates the entered base URL to have a valid stream wrapper registered. So nothing can go wrong any longer if systems are not properly configured or missing the core requirements.

Now fully tested with ftp/http/https and without URL.

Tested well, committed.