Since edit sections are usually placed on a page multiple times it is not standards compliant to use Ids in the HTML, I would like to request these be changed to Classes, and maybe a unique Id be added, so for example instead of:

<span id="edit-section">...</span>

It would be

<span class="edit-section" id="edit-section-1">...</span>

Adding the unique Ids as well as Classes may help some themers when building a theme and want to alter a specific section's styling.

Thank you
Aaron

CommentFileSizeAuthor
#1 edit_section-fixed_markup_and_accessibility-2473411-0.patch1.12 KBAaronMcHale
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

AaronMcHale’s picture

AaronMcHale
Primary language English
Location Edinburgh, Scotland
CreditAttribution: AaronMcHale commented
Status: Active » Needs review
FileSize
edit_section-fixed_markup_and_accessibility-2473411-0.patch1.12 KB

Patch of my changes, also added a title attribute to the edit link for accessibility, if anyone knows how to get a variable of the section title, that would be appreciated as that's what I was going for, but unfortunately don't have enough time to read through the code trying to find a way to get it.

  • pifagor committed dd0f7c3 on 7.x-1.x 
    Issue #2282459 by WillowDigit: Make edit section compatible with...
pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor as a volunteer and at Drupal Ukraine Community, GOLEMS GABB for Drupal Ukraine Community, GOLEMS GABB commented
Status: Needs review » Fixed

Done

pifagor’s picture

pifagor
Location 🇺🇦 Rivne
CreditAttribution: pifagor as a volunteer and at Drupal Ukraine Community for Drupal Ukraine Community commented
Status: Fixed » Closed (fixed)