Closed (fixed)
Project:
Translation Management Tool
Version:
8.x-1.x-dev
Component:
Core
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
16 Apr 2015 at 11:13 UTC
Updated:
7 May 2015 at 12:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
sasanikolic commentedComment #2
miro_dietikerThis is not only major, but the other issue is broken. So this needs to happen as part of the other issue.
Comment #3
berdirThe problem exists in HEAD, so separate issue makes sense :)
+1 on major.
Comment #4
miro_dietikerAlso note that the HTML validation is broken with text format... Dunno if this needs a separate issue.
Comment #5
sasanikolic commentedComment #6
sasanikolic commentedExpanded the test for nested arrays.
Also we found out that we get lots of errors when the translator does not have the correct permissions. Check #1415234: Deal with text format permissions and security.
Comment #8
berdirset() has no return value.
Now we need to actually fix this, with the fix from interdiff in the other issue, but in a way that it doesn't break non-formatted texts.
Comment #9
berdirAnd the test also needs to verify that we store the translation correctly.
Comment #10
sasanikolic commentedAdded the check for the translated text and fixed the issue.
Comment #11
miro_dietikerOK i see we have now a test that takes care of nested things in the dummy source and test translator.
I fear the fact that we don't have a web test with real nodes with both cases of unformatted and formatted (wysiwyg) fields going through the whole chain. Do we have?
Comment #12
sasanikolic commentedChanged the test and made sure that we correctly assert the translated text.
Comment #13
sasanikolic commentedThe node test didn't set a format, so we didn't have any existing tests that were using text formats and saving translations. This should fix it.
Comment #14
berdirThanks, looks good now.
Comment #15
miro_dietikerCommitted.