- Shopping Cart View
- Shopping Cart Block Plugin - embeds the Cart View(s), settings available.

CommentFileSizeAuthor
#10 create_a_shopping_cart-2472263-10.patch25.61 KBmglaman
#8 cart-icon-2472263-08.patch8.44 KBjoshmiller

Comments

vasike’s picture

vasike
Location Ramnicu Valcea
commented
Status: Active » Needs review

https://github.com/commerceguys/commerce/pull/182
There is a pull request on this.

vasike’s picture

vasike
Location Ramnicu Valcea
commented

pull request updated for the changes from https://github.com/commerceguys/commerce/pull/189
line_items instead of line_item

smccabe’s picture

smccabe commented
Status: Needs review » Closed (fixed)

This has been merged in so I think it can be marked as closed now.

vasike’s picture

vasike
Location Ramnicu Valcea
commented
Status: Closed (fixed) » Needs work

The PR merged (https://github.com/commerceguys/commerce/pull/189) is not the pone for this issue (even it was API related).

vasike’s picture

vasike
Location Ramnicu Valcea
commented
Status: Needs work » Needs review

PR updated, using the Cart page approach
- Add new setting for the Order type to select the Cart block view
- Re-work the CartBlock plugin to use the CartProvider the same way Cart page does.
- (and ofcourse) Update the default Cart Block View.

https://github.com/drupalcommerce/commerce/pull/182

bojanz’s picture

bojanz commented
Status: Needs review » Needs work

I did research (about 25 ecommerce sites, other ecommerce software), to see what the expected UX is.
All of them have a cart icon showing the number of items in the cart (similar to the Kickstart cart block), and optionally show a div with the cart contents on click.

mglaman will continue working on vasike's patch to achieve that UX.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Assigned: Unassigned » mglaman

Picking up the baton

joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
commented
StatusFileSize
new cart-icon-2472263-08.patch8.44 KB

Attached is a diff that is the same as the PR linked here: https://github.com/drupalcommerce/commerce/pull/315

It simple includes the cart icon sans Druplicon as requested by Matt Glaman.

  • bojanz committed 8355f34 on 8.x-2.x 
    Merge pull request #315 from joshmiller83/simple-cart

Issue #2472263:...
  • joshmiller committed 9a7747b on 8.x-2.x
    Issue #2472263: Add cart icon
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new create_a_shopping_cart-2472263-10.patch25.61 KB

PR: https://github.com/drupalcommerce/commerce/pull/318

Here is patch. Uses Josh's icons, provides a cart block with hover dropdown to show item details. Has two CSS files. One is base layout, another is theming. That way people can easily remove some of the CSS added so it looks okay out of the box with Bartik (and not need to drop !important or others.)

bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Boom. Merged

Demonstration: https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/42097/2402971/...

  • mglaman committed dac02da on 8.x-2.x 
    Issue #2472263 by vasike, smccabe, mglaman: Create a Shopping cart block
  • bojanz committed fa76aba on 8.x-2.x
    Merge pull request #318 from mglaman/2472263-shopping-cart-block

Issue...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.