[D7] Hide toolbar when printing

Patch works great!

Having the toolbar clobber the printout when you are printing out field lists and similar when debugging is a PITA.
This is already fixed in Drupal 8, but we need it in Drupal 7 as well.

Looks fine for me.

Bumping to 7.61, this didn't make it into 7.60

A quick review (noting I am not a CSS expert).

There are hardly any media queries in D7 core's CSS; I can only see a handful in the simpletest module. They're very well supported across all modern browsers though.

However, it doesn't look like it would work to add these rules to an existing print.css file, and I'd imagine adding a print.css file to the toolbar module would be unnecessarily complicated. Adding the rules to the toolbar module definitely makes sense.

The patch looks very similar to the one committed to D8 in #2403639: Remove toolbar from print view.

So this looks to me like a low-risk, pragmatic fix which is worth doing.

(not a css specialist by any account either) :-)

I would like to point out that this solution is not supported by IE8 (and earlier). (https://www.w3schools.com/cssref/css3_pr_mediaquery.asp as reported in the link previously posted by mcdruid)
Which may still be important to support and is listed as a supported browser by D7 in the documentation
(https://www.drupal.org/docs/7/system-requirements/browser-requirements ).
I am not really aware of the current strategic approach to this however.

An alternative that would support IE8 would be adding this inside a print.css file (the complicated option), that would produce the following HTML:
<link rel="stylesheet" type="text/css" href="print.css" media="print">

Thoughts? Will set this back to "Needs work" for now.

IE8 is a security risk and has virtually zero usage in 2019

Effective January 12, 2016, Internet Explorer 8 is no longer supported on any client or server version of Windows

jQuery UI version 12.1 removed support for IE8 in 2016
https://jqueryui.com/changelog/1.12.0/

Please update the supported browsers page silently and remove any mention of IE8.

ah ok, I'm not against the change proposted by Stefanos if it means maintaining status quo.

Stefanos, do you really think IE8 is worth any effort at all other than the effort to quietly remove the mention of it in the supported browsers page?

Here is a patch that doesn't utilize media queries and produces the following HTML:

<style type="text/css" media="print">
@import url("http://d7.site/modules/toolbar/toolbar-print.css?q0grxl");
</style>

@joseph.olstad: I think that the media attribute approach is legit and does solve the issue while keeping IE8 and earlier in the picture.

Looks good thanks @Stefanos!

Thanks @stefanos.petrakis, I think it's better to do it this way rather than introduce media queries where there are currently (almost) none in D7 core.

@Fabianx knows the render system well, so it'll be good to get his review, but this LGTM.

RTBM - Let’s get that in.

Thank you contributors!