Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The Drupal\views\Tests\Plugin\FilterTest::testFilterQuery contains a test that checks for 4 results, but the comment and test message refer to no results. This patch fixes that.
Comment | File | Size | Author |
---|---|---|---|
#9 | interdiff.txt | 765 bytes | pguillard |
#9 | testfilterquery_wrong_msg-2471609-9.patch | 1.51 KB | pguillard |
#8 | Screen Shot 2015-05-29 at 23.27.00.png | 56.39 KB | Anonymous (not verified) |
#5 | testfilterquery_wrong_msg-2471609-5.patch | 1.51 KB | jcnventura |
Comments
Comment #1
jcnventura CreditAttribution: jcnventura commentedComment #2
pguillard CreditAttribution: pguillard commented+1
Comment #3
dawehnerSeems alright for me. In some world we could fix things and use
Safemarkup::format()
, if possible.Comment #4
webchickHm. Seems like we lost some valuable context in that documentation about why we are checking for 4 records.
Comment #5
jcnventura CreditAttribution: jcnventura commentedIt was not a case of losing valuable information, but yes, the comment can be a lot more verbose on what's going on.
Comment #6
Anonymous (not verified) CreditAttribution: Anonymous at XIO commentedLooks good. A nitpick though:
'= John' should go up a line as to not violate or coding standards.
Comment #7
jcnventura CreditAttribution: jcnventura commentedThe 80-char max? I believe doing what you ask would actually break it...
Is there an obscure coding standard that I'm not aware here?
Comment #8
Anonymous (not verified) CreditAttribution: Anonymous at XIO commentedThe 80 chars indeed. In the screenshot below, I edited the html source of the dreditor view to demonstrate how I think it should look like.
Comment #9
pguillard CreditAttribution: pguillard commentedActually we are exactly on the 80 chars limit !
Comment #10
jcnventura CreditAttribution: jcnventura commentedComment #11
Anonymous (not verified) CreditAttribution: Anonymous at XIO commentedYes, indeed :)
Comment #14
jcnventura CreditAttribution: jcnventura commentedComment #17
pguillard CreditAttribution: pguillard commentedI raised the re-testing because tests are positive
Comment #18
pguillard CreditAttribution: pguillard commentedComment #19
alexpottCommitted 836d463 and pushed to 8.0.x. Thanks!