Problem/Motivation

The user inteface text of the Entity Reference module got changed since the hook_help text got committed.

The field settings use "Type of item to reference", not "entity type", so that needs changing in uses "Selecting reference type".

The rest of the uses refers to "entity reference", but that still makes sense.

Proposed resolution

Rewrite the Select reference type use

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#5 update_hook_help_text-2470910-5.patch1.54 KBpieterjanput
#2 update_hook_help_text-2470910-2.patch1.59 KBpieterjanput

Comments

ifrik’s picture

ifrik
she/her
commented
Category: Bug report » Task
Issue tags: +Novice
pieterjanput’s picture

pieterjanput commented
Status: Active » Needs review
StatusFileSize
new update_hook_help_text-2470910-2.patch1.59 KB

Status: Needs review » Needs work

The last submitted patch, 2: update_hook_help_text-2470910-2.patch, failed testing.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented

Try git diff origin/8.0.x > update_hook_help_text-2470910-5.patch since you patch has wrong format. You can find more info about creating patches in advanced patch contributor guide

pieterjanput’s picture

pieterjanput commented
Status: Needs work » Needs review
StatusFileSize
new update_hook_help_text-2470910-5.patch1.54 KB
pieterjanput’s picture

pieterjanput commented
Issue tags: +drupaldevdays
ifrik’s picture

ifrik
she/her
commented
Status: Needs review » Reviewed & tested by the community

Thanks PietJanPut,

The patch works as intended. The text is changed and now reflects the user interface text.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Looks good to me, thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed e43e444 on 8.0.x 
    Issue #2470910 by PieterJanPut, ifrik: Update hook_help text for Entity...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.