The 8.x-1.x branch is completely outdated and needs a real port now that the D8 API is done.

Ideally, this should start with the minimal effort to get the module to run in a test site - no switch to the Entity API (which might be an idea for later).

In order from least to most complex:

- xbbcode.info.yml
- PSR-{0->4}
- hook_menu()
- Forms
- Filter API

Comments

cburschka’s picture

The work is experimental, and will be tracked in the non-release branch "d8-port" until it's somewhat ready for testing.

(Note that this branch is temporary and may disappear or change its history without warning.)

Edit: d8-port is gone; development now happens in 8.x-2.x.

cburschka’s picture

Issue summary: View changes

Done with the easiest part.

cburschka’s picture

Issue summary: View changes

The Routing switch is basically done.

cburschka’s picture

Status: Active » Needs review
StatusFileSize
new8.68 KB

Here are a few updates to functions that used to be in the global scope (user_*, module_*, cache(), l(), url(), etc.)

eric_a’s picture

Wonderfull to see this D8 activity! I'm planning to convert the chessboard-8.x-2.x filter module to xbbcode.

Seems to me that plugins would be perfect for tags. For user defined tags you'd use plugin derivers. Also, would be great to switch "markup" to use the D8 Twig inline templates system. Existing markup templates would simply move from { and } to {{ and }}. Perhaps rename markup to template or just add the template key; then this could even be ported to 7.x-1.x.

cburschka’s picture

That's certainly an interesting idea! Tags would be basically be like small filter plugins.

  • cburschka committed d090afb on 8.x-2.x
    Issue #2470805: Port XBBCode to Drupal 8 (2)
    
    Move lib/Drupal/xbbcode to...
  • cburschka committed c7b0cd7 on 8.x-2.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    Changed some...

  • cburschka committed f9cb529 on 8.x-2.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    This patch makes...

  • cburschka committed b2ff83f on 8.x-2.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    Complete the...
cburschka’s picture

Status: Needs review » Active

The global settings part is done. The filter-specific settings might still need a bit of work, and then of course the filter has to actually process text.

  • cburschka committed 2809cd8 on 8.x-2.x
    Follow-up to #2470805: Remove debug message.
    

  • cburschka committed 209a949 on 8.x-2.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    A few minor...
cburschka’s picture

StatusFileSize
new1.67 KB

This patch uses FilterProcessResult() to return the processed text.

(Also, some stuff is now marked as private.)

cburschka’s picture

The filter object should not be passed to the tag processor. There are very few reasons why you might use it, and even less of them are a good idea.

In line with the filter API itself hiding the format from the filter plugin instance, this patch now hides the filter from the tag processor.

  • cburschka committed 32e4c92 on 8.x-2.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    Do not pass the $...
  • cburschka committed 7d88989 on 8.x-2.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    ::process() must...

  • cburschka committed 267494f on 8.x-2.x-historic
    Follow-up to #2470805: Remove debug message.
    
  • cburschka committed 426b5b4 on 8.x-2.x-historic
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    Do not pass the $...
  • cburschka committed 76e93d1 on 8.x-2.x-historic
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    ::process() must...
  • cburschka committed 93702e6 on 8.x-2.x-historic
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    A few minor...
  • cburschka committed a5f3c19 on 8.x-2.x-historic
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    This patch makes...
  • cburschka committed b6dde0c on 8.x-2.x-historic
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    Changed some...
  • cburschka committed c0ca343 on 8.x-2.x-historic
    Issue #2470805: Port XBBCode to Drupal 8 (2)
    
    Move lib/Drupal/xbbcode to...
  • cburschka committed f699510 on 8.x-2.x-historic
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    Complete the...
pgn4web’s picture

Is a port of XBBCode to Drupal 8 still being developed or planned?
Or should I look for alternatives?

Kind of amazing that the ability to create custom BBCodes has not built-in directly in the Drupal platform.

cburschka’s picture

I'm still planning to finish the port; I just haven't had a lot of time lately. :)

I should be able to get some work done next month. If I remember correctly, the port itself doesn't take much more, as long as some of the major architectural changes are left for a later version.

cburschka’s picture

Version: 8.x-1.x-dev » 8.x-2.x-dev

(dev work is happening in 8.x-2.x)

  • cburschka committed 5c5ebce on 8.x-2.x
    Issue #2470805: Fix return type in XBBCodeFilter::tips().
    
    The short...

  • cburschka committed 267494f on 8.x-3.x
    Follow-up to #2470805: Remove debug message.
    
  • cburschka committed 426b5b4 on 8.x-3.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    Do not pass the $...
  • cburschka committed 76e93d1 on 8.x-3.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    ::process() must...
  • cburschka committed 93702e6 on 8.x-3.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    A few minor...
  • cburschka committed a5f3c19 on 8.x-3.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    This patch makes...
  • cburschka committed b6dde0c on 8.x-3.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    Changed some...
  • cburschka committed c0ca343 on 8.x-3.x
    Issue #2470805: Port XBBCode to Drupal 8 (2)
    
    Move lib/Drupal/xbbcode to...
  • cburschka committed e21a9a6 on 8.x-3.x
    Issue #2470805: Fix return type in XBBCodeFilter::tips().
    
    The short...
  • cburschka committed f699510 on 8.x-3.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    Complete the...
cburschka’s picture

Version: 8.x-2.x-dev » 8.x-3.x-dev
Status: Active » Fixed

The new port (8.x-3.x, plugin/entity-based) seems functional and isn't missing anything major (aside from cleanup and refactoring, as well as some more features that would be nice). An alpha may be ready within a few days.

cburschka’s picture

Status: Fixed » Needs review

Well, aside from the whole default tag package.

cburschka’s picture

Status: Needs review » Fixed

8.x-3.0-alpha1 is up.

  • cburschka committed 267494f on 9.x-1.x
    Follow-up to #2470805: Remove debug message.
    
  • cburschka committed 426b5b4 on 9.x-1.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    Do not pass the $...
  • cburschka committed 76e93d1 on 9.x-1.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    ::process() must...
  • cburschka committed 93702e6 on 9.x-1.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    A few minor...
  • cburschka committed a5f3c19 on 9.x-1.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    This patch makes...
  • cburschka committed b6dde0c on 9.x-1.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    Changed some...
  • cburschka committed c0ca343 on 9.x-1.x
    Issue #2470805: Port XBBCode to Drupal 8 (2)
    
    Move lib/Drupal/xbbcode to...
  • cburschka committed e21a9a6 on 9.x-1.x
    Issue #2470805: Fix return type in XBBCodeFilter::tips().
    
    The short...
  • cburschka committed f699510 on 9.x-1.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    Complete the...

  • cburschka committed 267494f on 9.x-2.x
    Follow-up to #2470805: Remove debug message.
    
  • cburschka committed 426b5b4 on 9.x-2.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    Do not pass the $...
  • cburschka committed 76e93d1 on 9.x-2.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    ::process() must...
  • cburschka committed 93702e6 on 9.x-2.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    A few minor...
  • cburschka committed a5f3c19 on 9.x-2.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    This patch makes...
  • cburschka committed b6dde0c on 9.x-2.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    Changed some...
  • cburschka committed c0ca343 on 9.x-2.x
    Issue #2470805: Port XBBCode to Drupal 8 (2)
    
    Move lib/Drupal/xbbcode to...
  • cburschka committed e21a9a6 on 9.x-2.x
    Issue #2470805: Fix return type in XBBCodeFilter::tips().
    
    The short...
  • cburschka committed f699510 on 9.x-2.x
    Issue #2470805 by cburschka: Port XBBCode to Drupal 8
    
    Complete the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.