Follow-up to #2425901: Remove calls to UrlGenerator->generateFromPath if possible

Problem/Motivation

UrlGenerator::generateFromPath() is deprecated, so the twig function using it also needs to be deprecated now and removed in the parent issue.

Proposed resolution

Mark method as deprecated.

Remaining tasks

API changes

CommentFileSizeAuthor
#1 2470569-1.patch615 bytespwolanin

Comments

pwolanin’s picture

pwolanin commented
Status: Needs work » Needs review
StatusFileSize
new 2470569-1.patch615 bytes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

OK.

pwolanin’s picture

pwolanin commented
Issue tags: +D8 Accelerate Dev Days
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed e7d2cd5 and pushed to 8.0.x. Thanks!

  • alexpott committed e7d2cd5 on 8.0.x 
    Issue #2470569 by pwolanin: Mark \Drupal\Core\Template\TwigExtension::...
star-szr’s picture

star-szr
he/him
Primary language English
commented

Just want to mention that somewhere along the way we'll need a change record because anyone using the url_from_path Twig function will be in for a surprise otherwise and it will be hard to track down why things have broken for them.

pwolanin’s picture

pwolanin commented

@Cottser - so this just markes it deprecated, it's not removed, and dawehner suggested we could change the implementation if we want to keep a version in 8.0.0

star-szr’s picture

star-szr
he/him
Primary language English
commented

@pwolanin - thanks! Sorry, I should have been clearer in my comment, I understand this is just deprecating. My point was more that people working in templates won't be looking here to see if things are deprecated or not :)

And if we have a way of keeping the functionality then that makes my comment moot, the implementation details don't matter for what I'm talking about.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.