This page admin/structure/block/block-content/types has page title "Edit". Oops. Should be "Custom block types" or something like that.

Screen shot of the custom block types page

CommentFileSizeAuthor
#15 No title appears on Files oveview page.png44.08 KBBalu Ertl
#14 missing-title-parameter-not-inserted-into.png49.88 KBBalu Ertl
#14 custom-blocks-library-page-title.gif654.14 KBBalu Ertl
#8 custom_block_types_page-2470155-8.patch543 bytesD Szkiba
#8 custom_block_types_page-2470155-8.patch543 bytesD Szkiba
#5 custom_block_types_page-2470155-3.patch541 bytesD Szkiba
badpagetitle.png58.52 KBjhodgdon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

D Szkiba’s picture

D Szkiba CreditAttribution: D Szkiba commented

I try to work on this as part of the Drupal developer days mentoring program.

D Szkiba’s picture

D Szkiba CreditAttribution: D Szkiba commented
Assigned: Unassigned » D Szkiba
Julfabre’s picture

Julfabre CreditAttribution: Julfabre commented
Assigned: D Szkiba » Julfabre
Issue tags: +drupaldevdays

I try to work on it in Drupal Dev Day's

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Issue tags: +Usability
D Szkiba’s picture

D Szkiba CreditAttribution: D Szkiba commented
Status: Active » Needs review
FileSize
custom_block_types_page-2470155-3.patch541 bytes

As suggested, I changed the title to "Custom block types".

Julfabre’s picture

Julfabre CreditAttribution: Julfabre commented

We see the same solution

meramo’s picture

meramo CreditAttribution: meramo commented

To be really consistent, we should keep the page title as "Custom block library" for both "Blocks" and "Types" sub-tabs.
If you check other pages, i.e. "Block layout", you will notice the page always inherits the title of the top tab.
We need someone from UX to cross-check this before setting to rtbc

D Szkiba’s picture

D Szkiba CreditAttribution: D Szkiba commented
FileSize
custom_block_types_page-2470155-8.patch543 bytes
custom_block_types_page-2470155-8.patch543 bytes

I agree. Changed the title to "Custom block library".

meramo’s picture

meramo CreditAttribution: meramo commented

Looks awesome! Let's wait for someone else to review and set to rtbc

Reno Greenleaf’s picture

Reno Greenleaf CreditAttribution: Reno Greenleaf commented
Status: Needs review » Reviewed & tested by the community

Checked. Looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 5728e48 and pushed to 8.0.x. Thanks!

  • alexpott committed 5728e48 on 
    Issue #2470155 by D Szkiba: Custom block types page has bad page title

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Balu Ertl’s picture

Balu Ertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
CreditAttribution: Balu Ertl as a volunteer commented
Status: Closed (fixed) » Needs work
FileSize
custom-blocks-library-page-title.gif654.14 KB
missing-title-parameter-not-inserted-into.png49.88 KB

I'm afraid this issue still persists, although in slightly other form.

    As shown on the attached screen recording, the situation is the following about these two:
  1. "Blocks" sub-tab (path: /admin/structure/block/block-content): BAD. No <h1 class="page-title"> element being generated and <title> element shows the site's name instead of an individual name of the current page.
  2. "Types" sub-tab (path: /admin/structure/block/block-content/types): OK.
    In the hope to help out developers I did some further testing:
  • Counter-tested against all core themes, but no any obvious relevancy discovered.
  • An other strange sign if we open the page's URL directly for example after a freshly switched theme, then "Blocks" tab also has the correct page title. But right after clicking over to "Types" and coming back it loses its title again.
  • After clicking on the gray/yellow star icon, then the %title parameter is not inserted into the resulting messages, see the still screenshot. Strings on l.d.o: ID #354076 (shortcut created) and ID #354080 (shortcut deleted).

Please correct me if I should open a new ticket for it, but thi issue seemed so relevant to my observation.

Balu Ertl’s picture

Balu Ertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
CreditAttribution: Balu Ertl as a volunteer commented
FileSize
No title appears on Files oveview page.png44.08 KB

The situation seems quite similar on the page /admin/content/files too. However in this case no any sub-tabs are involved at all.

Balu Ertl’s picture

Balu Ertl
he/him
Primary language Hungarian
Location Budapest 🇪🇺
CreditAttribution: Balu Ertl as a volunteer commented

After testing on freshly published D8beta13 release installed both on localhost and Simplytest.me, unable to reproduce the issue for both example URLs mentioned above: /admin/structure/block/block-content/types & /admin/content/files. Also tested against adding/deleteing shortcuts, the green message reads as expected. Ticket suggested to be set as fixed.

alx_benjamin’s picture

alx_benjamin CreditAttribution: alx_benjamin commented
Status: Needs work » Closed (fixed)

Cannot replicate either.
Changing status to Closed(fixed)

-------------------------------------------------
Sponsored by http://reallifedesign.co.uk/