Problem/Motivation

On the permissions page, the main button on the page is a standard button, when it should be a primary button.

There are three types of buttons supported in core and in the Seven style guide. Standard, primary, and danger.
It's important that the correct button types are used consistently throughout Drupal

Remaining tasks

Add the primary #button_type class to that form item, so it receives the correct class.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Feature because it does not meet usability standards
Issue priority Not critical because it's a minor usability problem
Unfrozen changes Unfrozen because it only changes markup
Prioritized changes The main goal of this issue is usability
CommentFileSizeAuthor
#3 save_permissions.jpg200.7 KBpakmanlh
#2 2469939-button-type-permission-page-2.patch758 bytesjoshi.rohit100
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 91,406 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

LewisNyman’s picture

joshi.rohit100’s picture

Status: Active » Needs review
FileSize
758 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 91,406 pass(es). View

Done.

pakmanlh’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
200.7 KB

Looks nice.

LewisNyman’s picture

Issue summary: View changes
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 68ca854 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.

  • alexpott committed 68ca854 on 8.0.x
    Issue #2469939 by joshi.rohit100: The permissions page doesn't have a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.