Problem/Motivation

On the appearance page (/admin/appearance) the "Save configuration" button is styled as a standard button when it should be styled as a primary button.

There are three types of buttons supported in core and in the Seven style guide. Standard, primary, and danger.
It's important that the correct button types are used consistently throughout Drupal

Remaining tasks

Add the primary #button_type class to that form item, so it receives the correct class.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because usability standards
Issue priority Not critical because minor defect
Unfrozen changes Unfrozen because it only changes markup
Prioritized changes The main goal of this issue is usability
Files: 
CommentFileSizeAuthor
#3 2469921-theme-primary-button-3.png168.94 KBckrina
#2 2469921-theme-primary-button-2.patch551 bytesjoshi.rohit100
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 91,423 pass(es). View

Comments

LewisNyman’s picture

Title: The appearance doesn't have a primary button » The appearance page doesn't have a primary button
joshi.rohit100’s picture

Status: Active » Needs review
FileSize
551 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 91,423 pass(es). View

Done.

ckrina’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
168.94 KB

The patch applies fine and looks ok. I'm attaching an screenshot with be before/after.

Theme primary button changed, 2469921

LewisNyman’s picture

Issue summary: View changes
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed ff04963 and pushed to 8.0.x. Thanks!

  • alexpott committed ff04963 on 8.0.x
    Issue #2469921 by joshi.rohit100: The appearance page doesn't have a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.