Problem/Motivation

On the The install new theme form (/admin/theme/install) the cancel link is styled as a link when it should be styled as a primary button

There are three types of buttons supported in core and in the Seven style guide. Standard, primary, and danger.
It's important that the correct button types are used consistently throughout Drupal

Remaining tasks

Add the primary #button_type class to that form item, so it receives the correct class.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because usability standards
Issue priority Not critical because minor usability defect
Unfrozen changes Unfrozen because it only changes markup
Prioritized changes The main goal of this issue is usability
CommentFileSizeAuthor
#3 2469917-theme-install-primary-button-3.png134.59 KBckrina
#1 theme-install-primary-button-2469917-1.patch574 bytestadityar

Comments

tadityar’s picture

tadityar commented
Status: Active » Needs review
StatusFileSize
new theme-install-primary-button-2469917-1.patch574 bytes
Cauliflower’s picture

Cauliflower commented

Patch applied and works as expected.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 2469917-theme-install-primary-button-3.png134.59 KB

The patch applies fine and looks ok. Here's an screenshot:

Primary button in theme install page

lewisnyman’s picture

lewisnyman
he/him
commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 2d53e2a and pushed to 8.0.x. Thanks!

  • alexpott committed 2d53e2a on 8.0.x 
    Issue #2469917 by tadityar: The install new theme page doesn't have a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.