Problem/Motivation

On the Edit image styles effect form (admin/config/media/image-styles/manage/large/add/image_crop) the cancel link is styled as a link when it should be styled as a button

There are three types of buttons supported in core and in the Seven style guide. Standard, primary, and danger.
It's important that the correct button types are used consistently throughout Drupal

Remaining tasks

Add the a button class to that link

CommentFileSizeAuthor
#5 2469911-add-button-class-image-effect-5.png115.74 KBckrina
#3 2469911-add-button-class-image-effect-3.patch568 bytesjoshi.rohit100

Comments

lewisnyman’s picture

lewisnyman
he/him
commented
Issue summary: View changes
lewisnyman’s picture

lewisnyman
he/him
commented
Title: The modules page doesn't have a primary button » The edit image styles form's cancel link should be styled a a button
joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Active » Needs review
StatusFileSize
new 2469911-add-button-class-image-effect-3.patch568 bytes

Done.

Cauliflower’s picture

Cauliflower commented

Patch applied and works as expected.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 2469911-add-button-class-image-effect-5.png115.74 KB

Applies fine and looks ok. Here's an screenshot:
2469911-add-button-class-image-effect-5.png

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 454203f and pushed to 8.0.x. Thanks!

  • alexpott committed 454203f on 8.0.x 
    Issue #2469911 by joshi.rohit100: The edit image styles form's cancel...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.