Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
On the Edit image styles effect form (admin/config/media/image-styles/manage/large/add/image_crop) the cancel link is styled as a link when it should be styled as a button
There are three types of buttons supported in core and in the Seven style guide. Standard, primary, and danger.
It's important that the correct button types are used consistently throughout Drupal
Remaining tasks
Add the a button class to that link
Comment | File | Size | Author |
---|---|---|---|
#5 | 2469911-add-button-class-image-effect-5.png | 115.74 KB | ckrina |
#3 | 2469911-add-button-class-image-effect-3.patch | 568 bytes | joshi.rohit100 |
Comments
Comment #1
LewisNymanComment #2
LewisNymanComment #3
joshi.rohit100Done.
Comment #4
Cauliflower CreditAttribution: Cauliflower commentedPatch applied and works as expected.
Comment #5
ckrinaApplies fine and looks ok. Here's an screenshot:
Comment #6
alexpottThis issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 454203f and pushed to 8.0.x. Thanks!