Problem/Motivation

On the extend/modules page, the main button on the page is a standard button, when it should be a primary button

There are three types of buttons supported in core and in the Seven style guide. Standard, primary, and danger.
It's important that the correct button types are used consistently throughout Drupal

Remaining tasks

Add the primary #button_type class to that form item, so it receives the correct class.

Files: 
CommentFileSizeAuthor
#5 2469889-button-type-modulepage-5.png101.27 KBckrina
#3 2469889-button-type-modulepage-3.patch531 bytesjoshi.rohit100
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 91,422 pass(es). View

Comments

LewisNyman’s picture

Issue tags: +Novice
LewisNyman’s picture

Issue summary: View changes
joshi.rohit100’s picture

Status: Active » Needs review
FileSize
531 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 91,422 pass(es). View

Done.

vpeltot’s picture

Issue tags: +drupaldevdays
+++ b/core/modules/system/src/Form/ModulesListForm.php
@@ -239,6 +239,7 @@ public function buildForm(array $form, FormStateInterface $form_state) {
+      '#button_type' => 'primary',

This change is OK for me.

ckrina’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
101.27 KB

It applies fine for me and also looks ok.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 4d9c9ff and pushed to 8.0.x. Thanks!

  • alexpott committed 4d9c9ff on 8.0.x
    Issue #2469889 by joshi.rohit100: The modules page doesn't have a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.