Problem/Motivation

On the extend/modules page, the main button on the page is a standard button, when it should be a primary button

There are three types of buttons supported in core and in the Seven style guide. Standard, primary, and danger.
It's important that the correct button types are used consistently throughout Drupal

Remaining tasks

Add the primary #button_type class to that form item, so it receives the correct class.

CommentFileSizeAuthor
#5 2469889-button-type-modulepage-5.png101.27 KBckrina
#3 2469889-button-type-modulepage-3.patch531 bytesjoshi.rohit100

Comments

lewisnyman’s picture

lewisnyman
he/him
commented
Issue tags: +Novice
lewisnyman’s picture

lewisnyman
he/him
commented
Issue summary: View changes
joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Active » Needs review
StatusFileSize
new 2469889-button-type-modulepage-3.patch531 bytes

Done.

vpeltot’s picture

vpeltot commented
Issue tags: +drupaldevdays 
+++ b/core/modules/system/src/Form/ModulesListForm.php
@@ -239,6 +239,7 @@ public function buildForm(array $form, FormStateInterface $form_state) {
+      '#button_type' => 'primary',

This change is OK for me.

ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 2469889-button-type-modulepage-5.png101.27 KB

It applies fine for me and also looks ok.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 4d9c9ff and pushed to 8.0.x. Thanks!

  • alexpott committed 4d9c9ff on 8.0.x 
    Issue #2469889 by joshi.rohit100: The modules page doesn't have a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.