Hi,

This is a clone of https://www.drupal.org/node/2454865

I am using getlocations fields to get the user to fill his location (and get geocoded data) and now I want to display a facet based on the city which we get from the getlocations fields. Also I want to display the name which we get from getlocations fields as a sub-facet for the corresponding city but I am unable to do it.

When I enable a facet for it, I get a lot of unnecessary key words. (Like, all my titles also appear in this list)

Could someone help me out with getting this work ?

Image : https://www.drupal.org/files/issues/get.png ... as you can see, other than the city, lots of other keywords appear in the facet !

CommentFileSizeAuthor
#10 search_api-fix-facets-on-full-text-fields-2469547-9.patch2.7 KBdragos-dumi
#10 search_api-fix-facets-on-full-text-fields-2469547-9--testonly.patch1.46 KBdragos-dumi
#5 2469547-5--fix_fulltext_field_facets--interdiff.txt888 bytesdrunken monkey
#5 2469547-5--fix_fulltext_field_facets--tests_only.patch1.35 KBdrunken monkey
#5 2469547-5--fix_fulltext_field_facets.patch2.42 KBdrunken monkey
#4 2469547-4--fix_fulltext_field_facets--interdiff.txt1017 bytesdrunken monkey
#4 2469547-4--fix_fulltext_field_facets--tests_only.patch1.49 KBdrunken monkey
#4 2469547-4--fix_fulltext_field_facets.patch2.56 KBdrunken monkey
#1 2469547-1--fix_fulltext_field_facets--tests_only.patch1.32 KBdrunken monkey
#1 2469547-1--fix_fulltext_field_facets.patch2.39 KBdrunken monkey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Project: Search API » Search API Database Search
Status: Active » Needs review
FileSize
2469547-1--fix_fulltext_field_facets.patch2.39 KB
2469547-1--fix_fulltext_field_facets--tests_only.patch1.32 KB

Thanks for reporting this problem!
After a quick look at the code it seems we have an error in our facetting code for fulltext fields, which means that facets on a fulltext field will combine the values of all those fields. (At least if I'm right in assuming you're using the "Database" service class for your server?)
Please test whether the attached patch (with no --test_only suffix) solves your problem!

The last submitted patch, 1: 2469547-1--fix_fulltext_field_facets.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 1: 2469547-1--fix_fulltext_field_facets--tests_only.patch, failed testing.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Needs work » Needs review
FileSize
2469547-4--fix_fulltext_field_facets.patch2.56 KB
2469547-4--fix_fulltext_field_facets--tests_only.patch1.49 KB
2469547-4--fix_fulltext_field_facets--interdiff.txt1017 bytes

This one should pass.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
FileSize
2469547-5--fix_fulltext_field_facets.patch2.42 KB
2469547-5--fix_fulltext_field_facets--tests_only.patch1.35 KB
2469547-5--fix_fulltext_field_facets--interdiff.txt888 bytes

OK, the test is apparently not doing a very good job, and I see that we already have a solution (used in all other cases) for testing the returned facets. So, revised version attached.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Component: User interface » Code
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Title: Problem with getlocations » Fix facets on fulltext fields

Status: Needs review » Needs work

The last submitted patch, 5: 2469547-5--fix_fulltext_field_facets--tests_only.patch, failed testing.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Project: Search API Database Search » Search API
Version: 7.x-1.x-dev » 8.x-1.x-dev
Component: Code » Database backend
Status: Needs work » Patch (to be ported)
Issue tags: +Novice

Committed.
It seems the bug is there in D8, too, so moving the issue accordingly.

dragos-dumi’s picture

dragos-dumi CreditAttribution: dragos-dumi commented
Status: Patch (to be ported) » Needs review
FileSize
search_api-fix-facets-on-full-text-fields-2469547-9--testonly.patch1.46 KB
search_api-fix-facets-on-full-text-fields-2469547-9.patch2.7 KB

Ported the test for branch 8.x-1.x
Added patch only with the test - should fail and a complete patch

The last submitted patch, 10: search_api-fix-facets-on-full-text-fields-2469547-9--testonly.patch, failed testing.

The last submitted patch, 10: search_api-fix-facets-on-full-text-fields-2469547-9--testonly.patch, failed testing.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented

Looks great, thanks for the help!
Committed. (Only removed the two new blank lines.)

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.