Validation criteria of contextual filter stays active after unchecking 'Specify validation criteria'

@JinX-Be
Thank you for reporting this issue!

Do you want to give it a try in fixing it?

Let's see if this fixes the errors.

Unassigning Jinx-BE since he is having connection issues and can't do it himself :)

+++ b/core/modules/views/src/Plugin/views/argument/ArgumentPluginBase.php
@@ -1079,6 +1079,14 @@ public function getPlugin($type = 'argument_default', $name = NULL) {
+        if (isset($this->options['specify_validation']) && $this->options['specify_validation'] === 0) {

$this->options['specify_validation'] is supposed to be a boolean, I never really passed that if statement. So changed it to use empty() instead.

In addition I found some test views that didn't include the specify_validation option in their yml file, that seems wrong since those views did have a validation option but specify_validation would default to FALSE.

I also added test coverage.

Missed one, some of these test views are really weird.

After speaking to @dawener, we should take care of this at the submit level. When the argument options are submitted, we reset the validate options if the checkbox is unchecked.

Let's see if any tests break...and we also need to write tests for this.

The patch is small and started from scratch.

And the patch...

Yeah that approach is sooo much better, IMHO, but yeah, as you know, westill need some testcoverage.

Here's a test patch i've been working on...though I can't seem to get it working right at the end..the second postForm doesn't seem to save the changes in the handler and view..

Just using a boolean there works better for me.

Manually tested this. Followed the steps to reproduce and the issue still exists. After applying the patch and resaving the argument, the issue is fixed.

Little bit of nitpicking, looks good to me otherwise. And we have tests, yay!

+++ b/core/modules/views/src/Plugin/views/argument/ArgumentPluginBase.php
@@ -459,6 +459,12 @@ public function submitOptionsForm(&$form, FormStateInterface $form_state) {
+    // If the 'specify validation' checkbox is checked, reset the validation

+++ b/core/modules/views_ui/src/Tests/ArgumentValidatorTest.php
@@ -0,0 +1,63 @@
+   * Tests the Specify Validation functionality.

It's the 'Specify validation criteria' checkbox. And it should be 'is not checked'.

+++ b/core/modules/views_ui/src/Tests/ArgumentValidatorTest.php
@@ -0,0 +1,63 @@
+   * Tests the Specify Validation functionality.

Bit misleading, it doesn't test the actual functionality, it only tests setting the options. But since it's an UI test, that may be inferred.

+++ b/core/modules/views_ui/src/Tests/ArgumentValidatorTest.php
@@ -0,0 +1,63 @@
+    // Uncheck the 'specify validation' checkbox and expect the validation type

See 1, should be the 'Specify validation criteria' checkbox

+++ b/core/modules/views/src/Plugin/views/argument/ArgumentPluginBase.php
@@ -459,6 +459,12 @@ public function submitOptionsForm(&$form, FormStateInterface $form_state) {
+    // If the 'specify validation' checkbox is checked, reset the validation
+    // options.
+    if (empty($option_values['specify_validation'])) {
+      $option_values['validate']['type'] = 'none';
+    }

Should we also truncate the validation options?

Addressed #28 and #29.

Here we go. This should fix it.

+++ b/core/modules/views/src/Plugin/views/argument/ArgumentPluginBase.php
@@ -459,6 +459,14 @@ public function submitOptionsForm(&$form, FormStateInterface $form_state) {
+      $option_values['validate']['options'] = ['none' => []];

Maybe adding a quick comment why this is needed would be nice!

1. +++ b/core/modules/views_ui/src/Tests/ArgumentValidatorTest.php
   @@ -0,0 +1,63 @@
   +   *
   +   * @throws \Exception
   

   Seems pointless here to add it

2. +++ b/core/modules/views_ui/src/Tests/ArgumentValidatorTest.php
   @@ -0,0 +1,63 @@
   +  private function saveArgumentHandlerWithValidationOptions($specify_validation) {
   

   let's just use protected, its how we roll

Here we go. The Exception thing was added by my PHPStorm :P

All issues raised so far seem addressed, looks good to me.

Committed and pushed to 8.0.x. Thanks!