When a user is blocked due to password expiration, the administrator can unblock the user via the "Expired accounts" page. The user will then have one day to log in and change their password. If the user does not log in within one day, they will be blocked again. At this point an administrator should be able to unblock the user again, but it does not work.

CommentFileSizeAuthor
#7 password_policy-7.x-1.x-fix_unblocking_reblocked_account-2468449-7.patch4.16 KBaohrvetpv
#5 password_policy-7.x-1.x-fix_unblocking_reblocked_account-2468449-5.patch4.16 KBaohrvetpv
#3 password_policy-7.x-1.x-fix_unblocking_reblocked_account-2468449-3.patch4.89 KBaohrvetpv
#2 password_policy-7.x-1.x-test_unblock_reblocked_account-2468449-2.patch2.54 KBaohrvetpv
#1 password_policy-7.x-1.x-test_unblock_reblocked_account-2468449-1.patch3.33 KBaohrvetpv

Comments

aohrvetpv’s picture

aohrvetpv commented
StatusFileSize
new password_policy-7.x-1.x-test_unblock_reblocked_account-2468449-1.patch3.33 KB

Test to reproduce the bug. Requires first applying the patch in #2467941: Mock time retrievals for testing, which allows the test to control time.

aohrvetpv’s picture

aohrvetpv commented
StatusFileSize
new password_policy-7.x-1.x-test_unblock_reblocked_account-2468449-2.patch2.54 KB

Updated test to reproduce the bug. No longer requires applying a second patch as did previous patch.

aohrvetpv’s picture

aohrvetpv commented
Status: Active » Needs review
StatusFileSize
new password_policy-7.x-1.x-fix_unblocking_reblocked_account-2468449-3.patch4.89 KB

Fixed bug.

The problem was the existing code expected "unblocked" to be null for a user who had been blocked due to password expiration. But when a user was blocked after being unblocked, "unblocked" is not null; it is the time the user was unblocked. So we add a condition that detects when a user has been reblocked after being unblocked.

Also expanded test to actually attempt logins.

AohRveTPV queued 3: password_policy-7.x-1.x-fix_unblocking_reblocked_account-2468449-3.patch for re-testing.

aohrvetpv’s picture

aohrvetpv commented
StatusFileSize
new password_policy-7.x-1.x-fix_unblocking_reblocked_account-2468449-5.patch4.16 KB

Updated to apply on latest code.

Status: Needs review » Needs work

The last submitted patch, 5: password_policy-7.x-1.x-fix_unblocking_reblocked_account-2468449-5.patch, failed testing.

aohrvetpv’s picture

aohrvetpv commented
Status: Needs work » Needs review
StatusFileSize
new password_policy-7.x-1.x-fix_unblocking_reblocked_account-2468449-7.patch4.16 KB

Attempted to fix previous patch.

  • AohRveTPV committed 937d4ab on 7.x-1.x 
    Issue #2468449 by AohRveTPV: Cannot unblock reblocked expired account
aohrvetpv’s picture

aohrvetpv commented
Status: Needs review » Patch (to be ported)
aohrvetpv’s picture

aohrvetpv commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
aohrvetpv’s picture

aohrvetpv commented
Status: Patch (to be ported) » Closed (won't fix)

6.x-1.x is no longer supported.