Readmore.js has updated,it use a new variable "collapsedHeight" to decide the height vlaue of text before collapse,without this $element, user can not set this important value. at present, you have to edit the orignal Readmore.js to modify the value, or you must add a new virable collapsedHeight in module file, like the other option's code format.

CommentFileSizeAuthor
#3 readmore_js_has-2468161-3.patch1.5 KBalansaviolobo
#1 readmore_formatter.patch1.58 KBalansaviolobo

Comments

alansaviolobo’s picture

alansaviolobo commented
Status: Active » Needs review
StatusFileSize
new readmore_formatter.patch1.58 KB

added the new configuration.

Status: Needs review » Needs work

The last submitted patch, 1: readmore_formatter.patch, failed testing.

alansaviolobo’s picture

alansaviolobo commented
StatusFileSize
new readmore_js_has-2468161-3.patch1.5 KB

as per the defaults mentioned in the latest readmore.js,

defaults = {
        speed: 100,
        collapsedHeight: 200,
        heightMargin: 16,
        moreLink: '<a href="#">Read More</a>',
        lessLink: '<a href="#">Close</a>',
        embedCSS: true,
        blockCSS: 'display: block; width: 100%;',
        startOpen: false,

        // callbacks
        beforeToggle: function(){},
        afterToggle: function(){}
      },

The collapsedHeight parameter appears to be required and the maxHeight parameters appears to be unused. So renaming maxHeight to collapsedHeight.

alansaviolobo’s picture

alansaviolobo commented
Status: Needs work » Needs review
kurund’s picture

kurund commented

  • kurund committed a30cac2 on 7.x-1.x authored by alansaviolobo 
    Issue #2468161 by alansaviolobo: Readmore.js has updated,it use a new...
kurund’s picture

kurund commented
Assigned: homeworld_chinese » kurund
Status: Needs review » Closed (fixed)