From #2323531-5: Imagemagick port to Drupal 8:
Problem/Motivation
The plugin isn't picked up after a module install, because the plugin managers aren't following the plugin.manager naming pattern, so the plugin_manager_cache_clear tag would need to be added those.
Proposed resolution
Add plugin_manager_cache_clear tag to image.toolkit.manager and image.toolkit.operation.manager.
Remaining tasks
- Review patch
User interface changes
None
API changes
None
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 2467775-1.patch | 710 bytes | mondrake |
Comments
Comment #1
mondrakeComment #2
mondrakeComment #3
xanoGood catch.
Can anyone say if we test for this type of integration and if so, how? I tried to find a test that does this, but couldn't find any.
Comment #4
berdirLooks good to me as well. #2419005: Aggregator: Uncaught PHP Exception Drupal\Component\Plugin\Exception\PluginNotFoundException: "The "FeedTitle" plugin does not exist." was a similar problem, and it added a pretty weird test IMHO. I think this is OK, the worst case is that a manual cache clear is enabled after installing the module.
Let's see what core committers think about test coverage.
Comment #5
alexpottWe know that the
plugin_manager_cache_clearfunctionality works and is tested - I'm okay with not adding a specific test.Committed 79be8cf and pushed to 8.0.x. Thanks!