The 'Edit draft' link of the newest revision on the Node Moderate Tab points to node/%/edit instead of the edit page of the revision. This way you're never able to edit the latest version

See attached patch

CommentFileSizeAuthor
#2 workbench_moderation-fix-edit-draft-link-2467305-2.patch847 bytesnitebreed
workbench_moderation-edit_draft.patch1.2 KBnitebreed

Comments

das-peter’s picture

das-peter commented
Status: Needs review » Needs work

Thanks for the patch, unfortunately it doesn't seem to apply anymore - I couldn't find the code manually either.
Please re-roll & please create patches within the module directory - so that the patch doesn't point to sites/all/modules/contrib/workbench_moderation.

nitebreed’s picture

nitebreed
Primary language Dutch
commented
StatusFileSize
new workbench_moderation-fix-edit-draft-link-2467305-2.patch847 bytes

You were right, that patch was added trough SVN. Attached you find the GIT patch instead.

nitebreed’s picture

nitebreed
Primary language Dutch
commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
nitebreed’s picture

nitebreed
Primary language Dutch
commented
sylus’s picture

sylus commented

I can't reproduce the problem that this patch is trying to fix? Shouldn't the edit draft always point to the current revision? Which according the logic is "node/{$revision->nid}/edit"

nitebreed’s picture

nitebreed
Primary language Dutch
commented

The current revision isn't always the latest revision and in my opinion you should be able once you created a draft (i.e. a newer revision than the current revision) to edit this draft. Without this fix, this is not possible.

sylus’s picture

sylus commented

Are you using the latest official release of workbench? Whenever I made a draft on top of of my current revision no matter what each and every subsequent draft that has the "edit draft" links always points to the appropriate draft. I must be missing something in terms of reproduction. Will take a further look.

nitebreed’s picture

nitebreed
Primary language Dutch
commented
Status: Needs work » Needs review