By andypost on
Change record status: 
Published (View all published change records)
Project: 
Drupal core
Introduced in branch: 
8.0.x
Issue links: 
https://www.drupal.org/node/2318579
Description: 

The function was used to add depth, divs and divs_final for comment entities bringing pollution of internal properties. Also this brings additional processing overhead.

Instead of calling this function each time when comment thread is loaded this logic moved to \Drupal\comment\CommentViewBuilder::buildComponents()

\Drupal\comment\CommentViewBuildergetBuildDefaults() now set #comment_threaded boolean property for each comment entity build array, pointing that comment should be rendered as threaded or not.

Also the build array for comment thread use #comment_indent and #comment_indent_final properties (only when threading enabled) to hold amount of indents needed to open and close for the comment.

Possible values for #comment_indent

  • negative - amount of indents to close
  • 0 - on the same level as previous comment
  • 1 - the comment needs indent, only one extra level of indenting even if the difference in depth is higher.
Impacts: 
Module developers
Themers
Updates Done (doc team, etc.)
Online documentation: 
Not done
Theming guide: 
Not done
Module developer documentation: 
Not done
Examples project: 
Not done
Coder Review: 
Not done
Coder Upgrade: 
Not done
Other: 
Other updates done