It is general best practice for contributed modules that include a makefile to name the file [module_name].make.example, instead of [module_name].make

Using the file extension .make.example allows people to use different versions and locations of the libraries than what is specified in manualcrop.make.

This also avoids failing builds when the libraries cannot be downloaded, like what is being experienced in #2442311: Unable to download jquery.imgareaselect in manualcrop.make.

There are many issues around drupal.org about this issue for other projects that explain why this naming convention is the best practice. Here's a couple:

CommentFileSizeAuthor
#1 manualcrop-rename_makefile-2466233-1.patch1.64 KBgenjohnson

Comments

genjohnson’s picture

genjohnson commented
StatusFileSize
new manualcrop-rename_makefile-2466233-1.patch1.64 KB

Here's a patch that renames manualcrop.make to manualcrop.make.example.

genjohnson’s picture

genjohnson commented
Status: Active » Needs review
joewhitsitt’s picture

joewhitsitt
Location Iowa
commented
Status: Needs review » Reviewed & tested by the community

Makes sense to me. Thanks for providing examples of other issues.

  • Matthijs committed 02a54c9 on 7.x-1.x authored by genjohnson 
    Issue #2466233 by genjohnson: Renamed the .make file to .make.example
matthijs’s picture

matthijs
Primary language Dutch
commented
Status: Reviewed & tested by the community » Fixed

Patch committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.