FieldEntryFormController has a protected getFlagging() method to load a single flagging entity from FlagService::getFlaggings().
It could be useful to other modules to have this method available in FlagService.
Create patch.
None.
FieldEntryFormController would no longer need the protected getFlagging() method and would instead get the flagging from FlagService. And additional method to load a single flagging would be available on FlagService.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | interdiff-8-10.txt | 612 bytes | martin107 |
| #10 | getFlagging-2465875-10.patch | 2.64 KB | martin107 |
| #8 | interdiff-6-8.txt | 577 bytes | martin107 |
| #8 | getFlagging-2465875-8.patch | 2.67 KB | martin107 |
| #6 | getFlagging-2465875-6.patch | 2.67 KB | martin107 |
Comments
Comment #1
martin107 commentedThis has a conflict with #2464995: FieldEntryFormController::getFlagging() change the 'unfound' return type from FALSE to NULL - no biggie :)
Comment #2
martin107 commentedNow that #2461549: use entity type hinting in routes things have changed a little
1) The 2 controller functions that call this new service method preload the entity - so it makes sense to pass that entity in rather than the entities id.
2) The guts of the function can be simplified with
\Drupal::service('flag')->
becoming just
$this->
Comment #6
martin107 commentedReroll triggered by #2464995: FieldEntryFormController::getFlagging() change the 'unfound' return type from FALSE to NULL
I also added a minor touch up to the wording of getFlagging()
/**
* Get a flagging that already exists.
*
* @param FlagInterface $flag
* The flag.
* @param mixed $entity_id
* The flaggable ID.
*
* @return FlaggingInterface|null
- * The flagging or NULL.
+ * The flagging or NULL if the flagging is not found.
*/
Comment #8
martin107 commentedA little fix.
Comment #10
martin107 commentedFlagFieldEntryTest now passes locally.
Comment #11
socketwench commentedComment #13
socketwench commentedThanks!!!!