Needs review
Project:
ZURB Foundation
Version:
7.x-5.0-rc6
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 Apr 2015 at 02:29 UTC
Updated:
21 Jul 2017 at 18:41 UTC
Jump to comment: Most recent, Most recent file


Comments
Comment #1
nsciaccaIn the starter theme's scss/base/_drupal.scss it's setting the z-index to be below the default for the reveal modal bg (1004):
I was able to fix the background positioning by adding this:
This fixes the styles, but I can't seem to get the close button to work - any thoughts?
Comment #2
istryker commentedyes that did it, changing the background index to 998 fix the problem.
If by close button you mean the X in the top-right, I had no problem with it after I changed the bg z-index to 998.
Comment #3
nsciaccaYeah, it seems that using the theme option to show status messages in the reveal is missing an attribute for "data-reveal", which in turn breaks the closing functionality.
I have attached a patch that fixes the scss & css in the STARTER theme as well as the missing attribute.
Comment #4
nmillin commentedPatch by nsciacca worked for me. I was able to patch my existing sub-theme. Thanks!
Comment #5
torgospizzaWhile the patch did not apply for me, I think the solution was mainly to set the z-index for the bg element, and ensure that the output has the correct attributes, and the problem for me was solved.
Comment #6
zonesny commentedLikewise, I successfully applied patch in #3 (ran it with -p1 option in terminal, i.e. patch -p1 < modal_reveal-2465653.patch). Fixed same modal issue for me. Thanks nsciacca!
Comment #7
torgospizzaSeems this is RTBC then!
Comment #8
interdruper commented#3 fixes the issue for me too.
Comment #9
hongpong commentedThere is a big CSS change included in this patch? If we straighten this out I can commit it. Probably after updating composer.json to 6.3.1, then this patch will be much slimmer.