Coding standards state that type class names should be fully namespaced in @param and @return.

Postponed until #2461549: use entity type hinting in routes and follow-ups get in, as these will change parameters in various places.

CommentFileSizeAuthor
#10 fqdn-2465095-10.patch4.97 KBm1n0
#2 fqdn-2465095-2.patch4.94 KBmartin107

Comments

martin107’s picture

martin107 commented
Status: Postponed » Active
martin107’s picture

martin107 commented
StatusFileSize
new fqdn-2465095-2.patch4.94 KB

here is a patch from https://www.drupal.org/node/2476499#comment-9882267

which is technically the wrong issue for the patch

I am just posting it here just so it doesn't get dropped on the floor..

so specifically what was love-2476499-13.patch becomes fqdn-2465095-2.patch

pravin ajaaz’s picture

pravin ajaaz commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: fqdn-2465095-2.patch, failed testing.

Status: Needs work » Needs review

rajneeshb queued 2: fqdn-2465095-2.patch for re-testing.

joachim’s picture

joachim commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Looks like this needs a reroll.

snehi’s picture

snehi commented
Assigned: Unassigned » snehi
snehi’s picture

snehi commented
Assigned: snehi » Unassigned
priya.chat’s picture

priya.chat commented
Assigned: Unassigned » priya.chat
m1n0’s picture

m1n0 commented
StatusFileSize
new fqdn-2465095-10.patch4.97 KB

Rerolled patch, there was a file/interface name change in the meantime.

pravin ajaaz’s picture

pravin ajaaz commented
pravin ajaaz’s picture

pravin ajaaz commented
Status: Needs work » Needs review

  • joachim committed 8997404 on 8.x-4.x authored by martin107 
    Issue #2465095 by martin107, m1n0: Fixed classes in @param and @return...
joachim’s picture

joachim commented
Status: Needs review » Fixed

Thanks! Committed.

priya.chat’s picture

priya.chat commented
Assigned: priya.chat » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ivnish’s picture

ivnish
he/him
commented
Issue tags: -Novice, -Needs reroll