Steps to reproduce:
1. Install standard profile and setup node_embed
2. Create an article and enter [[nid:123]] in the body
3. Visit front page
You'll get the following error:
Error
The website encountered an unexpected error. Please try again later.
Error message
Recoverable fatal error: Argument 1 passed to _node_embed_user_feedback() must be an instance of stdClass, boolean given, called in /home/sd9835342ceab247/www/sites/default/modules/node_embed/node_embed.module on line 73 and defined in _node_embed_user_feedback() (line 110 of /home/sd9835342ceab247/www/sites/default/modules/node_embed/node_embed.module).
Comment | File | Size | Author |
---|---|---|---|
#2 | recoverable_fatal-2464391-2.patch | 2.21 KB | Tess Bakker |
Comments
Comment #1
olli CreditAttribution: olli commentedComment #2
Tess BakkerDifferent patch, different approach.
With patch #1, content editors won't be notified of removed nodes on non-node-pages like frontpage/views page/batch.
With this patch a dsm is set and a small error is displayed instead of the replacement token. This is needed, because some modules will remove [[..]] -tokens from the text.
@maintainer: If there isn't the need for a message, patch #1 is the way to go.
Comment #3
nadavoid CreditAttribution: nadavoid at Jackson River commentedI've tested #2 and it's working well for me. Thank you @Tessa Bakker!
Comment #4
kevincooper CreditAttribution: kevincooper commentedI have also tested #2 and it seems to be working.
Comment #5
szeidler CreditAttribution: szeidler at Ramsalt Lab commentedPatch #2 is working fine for me. I'm wondering if a non successfully loaded not, should not stack up at all, instead of catching it in the user feedback as #2 is doing it.
My approach would be something like this.
The issue itself is really important to fix, as it can happen with every invalid node id in the token or the more relevant case, that the referenced node got deleted. Also then you would see the fatal error.
Comment #7
paulvandenburg CreditAttribution: paulvandenburg commented