Closed (fixed)
Project:
Node Embed
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Apr 2015 at 11:21 UTC
Updated:
15 Aug 2019 at 13:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
olli commentedComment #2
tessa bakkerDifferent patch, different approach.
With patch #1, content editors won't be notified of removed nodes on non-node-pages like frontpage/views page/batch.
With this patch a dsm is set and a small error is displayed instead of the replacement token. This is needed, because some modules will remove [[..]] -tokens from the text.
@maintainer: If there isn't the need for a message, patch #1 is the way to go.
Comment #3
nadavoid commentedI've tested #2 and it's working well for me. Thank you @Tessa Bakker!
Comment #4
kevincooper commentedI have also tested #2 and it seems to be working.
Comment #5
szeidlerPatch #2 is working fine for me. I'm wondering if a non successfully loaded not, should not stack up at all, instead of catching it in the user feedback as #2 is doing it.
My approach would be something like this.
The issue itself is really important to fix, as it can happen with every invalid node id in the token or the more relevant case, that the referenced node got deleted. Also then you would see the fatal error.
Comment #7
paulvandenburg commented