Coming from a discussion here: #2163425: Automatically close the admin menu tray after using it on narrow screens I'd like to suggest it would be an improvement to the admin toolbar if it came with some configurable options.
The issue mentioned above is a good example, as some people will require the toolbar to always close after a menu link is clicked, others want it to close only on small screens. I think the admin module is a good example of how a few configuration options for admins create a lot more flexibility.
It might also be easier to make the toolbar much more customizable. Right now there are separate modules out in the wild that for instance allow other blocks/ menus to be added. But they need to be updated with each new release of the toolbar module. Imo it would be better to extend this module in a way where behaviors can be tweaked to the specific purpose of a project/ audience.
The toolbar is really beautiful and I can imagine people wanting to take more advantage of it, in various use cases.
Thanks!
Comments
Comment #1
alfthecat commentedComment #2
andrewmacpherson commentedComment #8
andrewmacpherson commentedusing preferred accessibility tag
Comment #9
andrewmacpherson commentedComment #14
nod_We wanted the toolbar to have no user-configuration, we had the toggle from vertical to horizontal but that is it. So it's not really the way the module was developped.
What kind of configuration options are we talking about, if we have an somewhat exhaustive list it'll be easier to discuss specifics and implementation if that's the way we're going.
In the state of things I'm not saying no, but it's not a yes either.
Comment #15
dwwFor example, #2801501: Option for the Toolbar *not* to auto-open the "Manage" sub-menu? would be a great global config option for a site that wanted to control that behavior (instead of applying the gnarly patch I have there now).
Comment #16
dwwAdded #1869638: Make the menu shown in the administration menu tray configurable as another child. That one has 2 other related on similar themes (possibly some duplicates).
Comment #20
pasqualleDrupal core should allow contrib to easily extend/modify its functionality. Currently the missing toolbar menu config is blocking the implementation of simple features in contrib, or at least making it overcomplicated.
Comment #21
nod_cross posting from #1869638-108: Make the menu shown in the administration menu tray configurable.
I'm not personally ready to support configuration (hidden or otherwise) for the toolbar module because it wasn't designed for it and I think the current situation, while not perfect, is good enough.
I wouldn't oppose someone stepping up that is ready to maintain this type of feature and deal with the associated maintenance it induces.
Comment #22
nod_To be clear, I'm asking for an additional maintainer, not someone to take up the whole module maintenance.
Before we start adding little pieces here and there of config I would prefer to figure out a plan (even a vague idea) about how this whole thing will work: what are we going to have configurable, with which granularity (sitewide, per user, per role?), are new permissions involved, how do we decide what should be configurable and what should not, etc.
toolbar is not an experimental module so once we release something it's stable and we can expect contrib to rely on it, it also means that changes will need a BC layer, and we've seen it's great for users but it's a lot of work on the maintenance side of things. Since it's new it's probably going to change a bunch of times before we get it just right (while keeping a minimum of a BC layer), this will introduce churn in core and in contrib. To avoid frustration someone should be a point of contact for this to centralize the knowledge and I don't have the will/time to do this work at the moment, which is why I'm looking for someone who does.
Comment #23
pasqualleComment #26
quietone commentedThe Toolbar Module was approved for removal in #3476882: [Policy] Move Toolbar module to contrib.
This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.
The deprecation work is in #3484850: [meta] Tasks to deprecate Toolbar module and the removal work in #3488828: [meta] Tasks to remove Toolbar module.
Toolbar will be moved to a contributed project before Drupal 12.0.0 is released.
Comment #27
aaronmchaleI feel like this could probably be closed, the new Navigation is much more flexible in what can go on the Navigation bar, you can have one or many menu blocks in there, so the usecase should be satisifed.