Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Improve YamlFileLoader so that we can cache built service definition objects and not just the raw data.
Proposed resolution
@todo
Remaining tasks
@todo
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#5 | remove-todo-from-yamlfileloader-2464053-5.patch | 725 bytes | marcoscano |
Comments
Comment #1
Fabianx CreditAttribution: Fabianx for Drupal Association commentedComment #2
mgiffordThe parent issue is fixed, so assuming this should be active now.
Comment #4
Fabianx CreditAttribution: Fabianx as a volunteer commentedThis issue is actually:
"Closed: Won't Fix"
but there is a dangling todo in core/lib/Drupal/Core/DependencyInjection/YamlFileLoader.php.
which references this issue.
Lets remove it!
The reason this is Won't fix is because I benchmarked it and the savings had been minimal (-168 ms) for 5-6 container rebuilds, but the effort / complexity is pretty huge.
=> Not worth it.
Diff here to preserve the approach, but it is _not_ worth it.
Comment #5
marcoscano"@todo removed" :)
Comment #6
Fabianx CreditAttribution: Fabianx as a volunteer commentedRTBC - Thank you!
Comment #7
Fabianx CreditAttribution: Fabianx as a volunteer commentedComment #8
alexpottCommitted 8fade5d and pushed to 8.1.x and 8.2.x. Thanks!
Comment #11
Fabianx CreditAttribution: Fabianx as a volunteer commented