Problem/Motivation

Needed a numeric machine name to pass codes for ACCPAC system but found out quickly the broke things in the menu.

The menu title callback for shipping is:

$items['admin/commerce/config/shipping/services/' . $service_name_arg] = array(
  'title callback' => 'commerce_shipping_service_get_title',
  'title arguments' => array($service_name),

Which will return a list, if there is no service name, but the tricky part is title arguments that are numeric are looking in the URL arguments.

Proposed resolution

Cast the title arguments to a string.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 numeric_machine_names-2463921-1.patch708 bytesjoelpittet

Comments

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Priority: Normal » Major
Status: Active » Needs review
StatusFileSize
new numeric_machine_names-2463921-1.patch708 bytes

Here's a patch and bumping priority as this can do some nasty error messages.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue summary: View changes
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue summary: View changes
googletorp’s picture

googletorp commented
Status: Needs review » Fixed

Reviewed and committed, thanks.

  • googletorp committed cd9e283 on 7.x-2.x authored by joelpittet 
    Issue #2463921 by joelpittet, googletorp: Numeric Machine Names break...
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Awesome thanks @googletorp.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.